Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trimming] preserve custom views and $(AndroidHttpClientHandlerType) #8954

Merged
merged 6 commits into from
Jun 17, 2024

Commits on May 16, 2024

  1. [trimming] preserve custom views and $(AndroidHttpClientHandlerType)

    Fixes: dotnet#8797
    
    Here are two cases `TrimMode=full` can break applications:
    
    * `$(AndroidHttpClientHandlerType)` set to a custom type
    
    * Custom views (Android `.xml`) that are not referenced in C# code
    
    In the `MarkJavaObjects` trimmer step we can preserve both of these
    cases by:
    
    * Passing in `$(AndroidHttpClientHandlerType)`, preserve the public,
      parameterless constructor of the type
    
    * Pass in `$(_CustomViewMapFile)`, preserve `IJavaObject` types if
      they are found in the map file
    jonathanpeppers committed May 16, 2024
    Configuration menu
    Copy the full SHA
    2163693 View commit details
    Browse the repository at this point in the history
  2. Fix apk tests

    jonathanpeppers committed May 16, 2024
    Configuration menu
    Copy the full SHA
    cebeb8a View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Configuration menu
    Copy the full SHA
    ef77b4e View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Configuration menu
    Copy the full SHA
    aef660c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7d84df7 View commit details
    Browse the repository at this point in the history
  3. Put namespace back

    jonathanpeppers committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    02e0514 View commit details
    Browse the repository at this point in the history