Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to Include Debugging.Tasks Versioning #8290

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Bump to Include Debugging.Tasks Versioning #8290

merged 1 commit into from
Sep 21, 2023

Conversation

dellis1972
Copy link
Contributor

@dellis1972 dellis1972 commented Aug 23, 2023 •
edited
Loading

@dellis1972
Copy link
Contributor Author

Weird output on failing fast deployment test.

LastWriteTime of `/Users/runner/work/1/a/TestRelease/08-23_13.59.46/temp/IncrementalFastDeployment/UnnamedProject/obj/Debug/upload.flag`: 1/1/1601 12:00:00 AM

Check out the date!!!!

@dellis1972 dellis1972 force-pushed the debugtasksversion branch 2 times, most recently from 608d984 to 81ebf81 Compare September 7, 2023 09:52
@dellis1972 dellis1972 changed the title Test Debugging.Tasks Versioning Bump to Include Debugging.Tasks Versioning Sep 7, 2023
@dellis1972 dellis1972 marked this pull request as ready for review September 7, 2023 13:51
@dellis1972 dellis1972 requested a review from jonpryor as a code owner September 7, 2023 13:51
@dellis1972 dellis1972 requested a review from pjcollins September 7, 2023 13:52
pjcollins
pjcollins approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@pjcollins pjcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build tasks and debugging tasks are both showing the same 13.2.99.452 version so this seems good to me. Maybe at some point in the future we'll want to switch to versioning that more closely matches our .NET workload/pack version?

@dellis1972 dellis1972 merged commit d958514 into dotnet:main Sep 21, 2023
45 of 47 checks passed
@dellis1972 dellis1972 deleted the debugtasksversion branch September 21, 2023 09:21
grendello added a commit to grendello/xamarin-android that referenced this pull request Sep 21, 2023
@grendello
Merge branch 'main' into all-assemblies-per-rid
87905aa 
* main:
  Bump to Include Debugging.Tasks Versioning (dotnet#8290)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pjcollins pjcollins pjcollins approved these changes

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@jonpryor jonpryor Awaiting requested review from jonpryor jonpryor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dellis1972 @jonathanpeppers @pjcollins