Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix monodroid COMMON_CFLAGS usage and always build with RELEASE. #82

Merged
merged 3 commits into from
Jul 12, 2016
Merged

Fix monodroid COMMON_CFLAGS usage and always build with RELEASE. #82

merged 3 commits into from
Jul 12, 2016

Commits on Jun 15, 2016

  1. Fix monodroid COMMON_CFLAGS usage and always build with RELEASE. 

    The primary problem was that when app launches it tries to load assemblies:

	W/monodroid( 2061): Using override path: /data/data/com.xamarin.android.helloworld/files/.__override__

It should not happen, because we don't have fastdev here.

However, it was weird, that the problem occured even with app Release builds.

Turned out that in src/monodroid, Android.mk referenced COMMON_FLAGS,
which did not exist. Fix typo.

Then, since we don't have fastdev, monodroid needs to be built always
in RELEASE mode. So, add -DRELEASE=1 even for Debug build.
    @atsushieno
    atsushieno committed Jun 15, 2016
    Configuration menu
    Copy the full SHA
    e2ebecb View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2016

  1. Merge branch 'master' into fix-monodroid-cflags-2

    @atsushieno
    atsushieno committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    a014321 View commit details
    Browse the repository at this point in the history

  2. Remove RELEASE build flag from common. Instead default xabuild to Rel… 

    …ease.
    @atsushieno
    atsushieno committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    52a53cc View commit details
    Browse the repository at this point in the history