Try xamarin/java.interop#1046 #7824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
force-pushed
the
jonp-try-ji-pr-1046
branch
from
c789791
to
c9d40c8
Compare
jonpryor
requested review from
grendello,
dellis1972 and
jonathanpeppers
as code owners
Context: dotnet/java-interop#1046 The assumption is that This Cannot Possibly Impact™ Android. So… Does It Build™? …no, it does not build, because dotnet/java-interop#1046 removes the `net472` build of `jnimarshalmethod-gen.exe`, which causes packaging to fail. Noice. Given that `jnimarshalmethod-gen.exe` only "worked" in Classic, and that main is (slowly) dropping support for Classic (618bd4a), update the repo to stop packaging `jnimarshalmethod-gen.*` and `Java.Runtime.Environment.*`. This should fix the packaging errors.
jonpryor
force-pushed
the
jonp-try-ji-pr-1046
branch
from
c9d40c8
to
567370a
Compare
pjcollins
reviewed
Feb 24, 2023
There was a problem hiding this comment.
The installer and build related changes here seem reasonable to me. If we want to add an error to the _GenerateJniMarshalMethods target we may want to provide localization for it, unless it is going to be short lived. On the other hand, if we don't plan to use this target again in the future should we remove it and its references instead?
jonpryor
force-pushed
the
jonp-try-ji-pr-1046
branch
from
912c3ac
to
7c8a333
Compare
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 28, 2023
* main: [monodroid] Properly process satellite assemblies (dotnet#7823) Bump to xamarin/java.interop/main@77800dda (dotnet#7824)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 28, 2023
* main: [monodroid] Properly process satellite assemblies (dotnet#7823) Bump to xamarin/java.interop/main@77800dda (dotnet#7824)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 28, 2023
* main: [Xamarin.Android.Build.Tasks] Remove support for mkbundle (dotnet#7772) [Xamarin.Android.Build.Tasks] `unable to open file as zip archive`? (dotnet#7759) [monodroid] Properly process satellite assemblies (dotnet#7823) Bump to xamarin/java.interop/main@77800dda (dotnet#7824)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Mar 6, 2023
* main: (22 commits) Bump to dotnet/installer@632ddca 8.0.100-preview.3.23128.1 (dotnet#7836) LEGO: Merge pull request 7852 [ci] Reduce overhead for MSBuildIntegration unit test jobs. (dotnet#7832) [ci] Allow dynamic`$(NuGetArtifactName)` values (dotnet#7848) [Xamarin.Android.Build.Tasks] guard `AutoImport.props` against empty values (dotnet#7837) [Mono.Android] Print type & member remapping info (dotnet#7844) [Mono.Android] Tweak AndroidMessageHandler behavior for WCF support (dotnet#7785) LEGO: Merge pull request 7845 Localized file check-in by OneLocBuild Task (dotnet#7842) [ci] Use compliance stage template (dotnet#7818) [build] pass `--skip-sign-check` to `dotnet workload` (dotnet#7840) Replace K4os.Hash.xxHash with System.IO.Hashing (dotnet#7831) $(AndroidPackVersionSuffix)=preview.3; net8 is 34.0.0-preview.3 (dotnet#7839) [Xamarin.Android.Build.Tasks] Remove support for mkbundle (dotnet#7772) [Xamarin.Android.Build.Tasks] `unable to open file as zip archive`? (dotnet#7759) [monodroid] Properly process satellite assemblies (dotnet#7823) Bump to xamarin/java.interop/main@77800dda (dotnet#7824) [ci] Use AZDO built-in parallelization strategy. (dotnet#7804) Bump to dotnet/installer@e3ab0b5 8.0.100-preview.2.23123.10 (dotnet#7813) [ci] Run nunit tests with stable .NET version (dotnet#7826) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/java-interop#1046
The assumption is that This Cannot Possibly Impact™ Android.
So… Does It Build™?
…no, it does not build, because dotnet/java-interop#1046 removes
the
net472build ofjnimarshalmethod-gen.exe, which causespackaging to fail. Noice.
Given that
jnimarshalmethod-gen.exeonly "worked" in Classic,and that main is (slowly) dropping support for Classic (618bd4a),
update the repo to stop packaging
jnimarshalmethod-gen.*andJava.Runtime.Environment.*. This should fix the packaging errors.