-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Only build the latest API level #7786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcollins
force-pushed
the
fewer-api-levels
branch
from
February 17, 2023 21:42
98662ba
to
f0015a3
Compare
Build timing from main: make jenkins 219.78s user 62.79s system 21% cpu 21:56.92 total Build timing from this branch: make jenkins 178.66s user 47.24s system 36% cpu 10:22.81 total
pjcollins
force-pushed
the
fewer-api-levels
branch
from
February 17, 2023 23:08
f0015a3
to
7e64bb0
Compare
grendello
approved these changes
Feb 20, 2023
jpobst
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍 Love it!
Since this is ready, it's fine if this goes before #7796. I can fix the conflicts if needed.
Updated commit message: Shaves ~10-15 minutes off of our Unix builds by only attempting to build
Mono.Android.dll for the latest API level. A local `make jenkins` build
went from ~22 minutes to ~10 minutes with these changes, and CI builds
see a similar time saving.
This seems like a reasonable incremental step towards classic removal,
and allows us to continue to produce classic .vsix and .pkg installers
for the time being.
The designer test stages have been removed as they rely on API 30 or
lower.
The Wear OS test job has been moved into the emulator job stage rather
than running in its own stage. |
jonathanpeppers
approved these changes
Feb 21, 2023
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 22, 2023
* main: [build] Only build the latest API level (dotnet#7786) [Xamarin.Android.Build.Tasks] Improve aapt2+file not found handling (dotnet#7644)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 22, 2023
* main: Add Unit Test for testOnly apps (dotnet#7637) [build] Only build the latest API level (dotnet#7786) [Xamarin.Android.Build.Tasks] Improve aapt2+file not found handling (dotnet#7644) [MSBuildDeviceIntegration] Fix duplicated test parameter (dotnet#7809)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 22, 2023
* main: Add Unit Test for testOnly apps (dotnet#7637) [build] Only build the latest API level (dotnet#7786) [Xamarin.Android.Build.Tasks] Improve aapt2+file not found handling (dotnet#7644) [MSBuildDeviceIntegration] Fix duplicated test parameter (dotnet#7809) [tests] Bump NUnit versions to latest (dotnet#7802) [Microsoft.Android.Sdk.ILLink] target `net7.0` temporarily (dotnet#7803) [tests] `InstallAndroidDependenciesTest` can use `platform-tools` 34.0.0 (dotnet#7800) Bump to xamarin/Java.Interop/main@9e0a469 (dotnet#7797) [Xamarin.Android.Build.Tasks] FileWrites&libraryprojectimports.cache (dotnet#7780) Bump to dotnet/installer@d25a3bb 8.0.100-preview.2.23105.6 (dotnet#7769)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 22, 2023
* main: Add Unit Test for testOnly apps (dotnet#7637) [build] Only build the latest API level (dotnet#7786) [Xamarin.Android.Build.Tasks] Improve aapt2+file not found handling (dotnet#7644) [MSBuildDeviceIntegration] Fix duplicated test parameter (dotnet#7809)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 22, 2023
* main: Add Unit Test for testOnly apps (dotnet#7637) [build] Only build the latest API level (dotnet#7786) [Xamarin.Android.Build.Tasks] Improve aapt2+file not found handling (dotnet#7644) [MSBuildDeviceIntegration] Fix duplicated test parameter (dotnet#7809) [tests] Bump NUnit versions to latest (dotnet#7802) [Microsoft.Android.Sdk.ILLink] target `net7.0` temporarily (dotnet#7803) [tests] `InstallAndroidDependenciesTest` can use `platform-tools` 34.0.0 (dotnet#7800) Bump to xamarin/Java.Interop/main@9e0a469 (dotnet#7797) [Xamarin.Android.Build.Tasks] FileWrites&libraryprojectimports.cache (dotnet#7780) Bump to dotnet/installer@d25a3bb 8.0.100-preview.2.23105.6 (dotnet#7769) [lgtm] Fix LGTM-reported issues (dotnet#1074) [ci] Report issues in the API docs build log (dotnet#7784)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 23, 2023
* main: LEGO: Merge pull request 7825 Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799) Bump NDK to r25c (dotnet#7808) [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816) [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822) Localized file check-in by OneLocBuild Task (dotnet#7820) Add Unit Test for testOnly apps (dotnet#7637) [build] Only build the latest API level (dotnet#7786)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 24, 2023
* main: LEGO: Merge pull request 7825 Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799) Bump NDK to r25c (dotnet#7808) [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816) [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822) Localized file check-in by OneLocBuild Task (dotnet#7820) Add Unit Test for testOnly apps (dotnet#7637) [build] Only build the latest API level (dotnet#7786)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build timing from main:
Build timing from this branch:
It looks like this will shave off about 10 minutes from the Linux build and 10-15 minutes from the macOS build in CI as well.
Rather than remove the classic installers entirely, this seems like a good incremental step towards obsoletion.
The designer tests have been removed as they rely on API 30 or lower.
The wear test job has been moved to the emulator test stage rather than running in its own stage.
Multiple API levels are still used in the following projects, and could be cleaned up in the future: