[tests] update .apkdesc files for failing tests
#7757
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7264347&view=ms.vss-test-web.build-test-results-tab&runId=67617676&resultId=100033&paneView=debug A single test was failing on Windows-only: BuildReleaseArm64(True) apkdiff regression test failed with exit code: 3 stdErr: Error: apkdiff: PackageSize decrease 8,192 is 3,072 bytes more than the threshold 5,120. apk1 size: 9,521,310 bytes, apk2 size: 9,513,118 bytes. Error: apkdiff: Size regression occured, 1 check(s) failed. Most notably a single file changed: 14,556 classes.dex I believe this started failing in 35db527, due to a combination of changes: * [dotnet/runtime#77386][0] introduced `libSystem.Security.Cryptography.Native.Android.jar` in the Mono runtime packs. * We updated `.apkdesc` files *before* including the new `.jar`. * We added appropriate logic to include the new `.jar`. The result was we have `.apkdesc` files that don't match the full set of changes in 35db527. Then in 8872d04 the app size changed beyond the threshold for a test to fail. [0]: dotnet/runtime#77386
dellis1972
approved these changes
Jan 31, 2023
|
Need to investigate more: |
|
I don't think this is needed anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7264347&view=ms.vss-test-web.build-test-results-tab&runId=67617676&resultId=100033&paneView=debug
A single test was failing on Windows-only:
Most notably a single file changed:
I believe this started failing in 35db527, due to a combination of changes:
dotnet/runtime#77386 introduced
libSystem.Security.Cryptography.Native.Android.jarin the Mono runtime packs.We updated
.apkdescfiles before including the new.jar.We added appropriate logic to include the new
.jar.The result was we have
.apkdescfiles that don't match the full set of changes in 35db527. Then in 8872d04 the app size changed beyond the threshold for a test to fail.