[One .NET] fix remaining Mono.Android.Export linker warning #6216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
dotnet-remove-dynamicdependency
branch
from
941f4a6
to
a957180
Compare
jonathanpeppers
changed the title
jonpryor
reviewed
Sep 2, 2021
| @@ -0,0 +1,92 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
There was a problem hiding this comment.
If this file was copied from elsewhere -- which I think it was -- then it should instead be in e.g. src-ThirdParty/….
This was overlooked with DynamicallyAccessedMemberTypes.cs and DynamicDependencyAttribute.cs, so those should likewise move. :-(
There was a problem hiding this comment.
These should be moved around now.
Context: dotnet#5652 If you build an app with: > dotnet build -c Release -p:SuppressTrimAnalysisWarnings=false You get the linker warning: src\Mono.Android\Android.Runtime\AndroidRuntime.cs(296,5): warning IL2026: Android.Runtime.AndroidTypeManager.CreateDynamicCallback(MethodInfo): Using method 'System.Reflection.Assembly.GetType(String)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Types might be removed. We can simply suppress the warning: [UnconditionalSuppressMessage ("Trimming", "IL2026", Justification = "DynamicDependency should preserve the Create() method.")] If we applied this, every app would preserve `Mono.Android.Export.dll`, so we should not do this: [DynamicDependency ("Create", "Java.Interop.DynamicCallbackCodeGenerator", "Mono.Android.Export")] This is already preserved because we have a `DynamicDependency` in `ExportAttribute.cs`: [DynamicDependency (DynamicallyAccessedMemberTypes.All, "Java.Interop.DynamicCallbackCodeGenerator", "Mono.Android.Export")] I also had to bring in the source for `UnconditionalSuppressMessage` for `monoandroid10` or `netstandard2.0` assemblies. I also changed an MSBuild `Condition`, so it will continue to work in .NET 7.
jonathanpeppers
force-pushed
the
dotnet-remove-dynamicdependency
branch
from
a957180
to
d09d391
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #5652
If you build an app with:
You get the linker warning:
We can simply suppress the warning:
If we applied this, every app would preserve
Mono.Android.Export.dll, so we should not do this:This is already preserved because we have a
DynamicDependencyinExportAttribute.cs:I also had to bring in the source for
UnconditionalSuppressMessagefor
monoandroid10ornetstandard2.0assemblies. I also changed anMSBuild
Condition, so it will continue to work in .NET 7.