[build] Fix mono version check on Linux #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commits 721c433, 469e628, and 986869b attempted to fix the macOS Jenkins build by using `mono --arch=32`/`mono32` to run `MonoAotOffsetsDumper.exe`, and by altering the mono version check to require mono 5.2.0.114, which was needed in order for macOS to provide the `mono32` binary in a location included in `$PATH`. Those commits *also* [broke the Linux+Jenkins build][0], by requiring a binary (`mono32`) that (1) doesn't exist on Linux, and (2) isn't needed on Linux (Linux requires a 64-bit process to invoke `MonoAotOffsetsDumper.exe`!): error : Missing dependency detected. For Linux we do not know how to install program `mono`, version >= 5.2.0.114 Mono 5.2.0 is pre-installed on that machine, but *not* 5.2.0.114. Update the mono version check so that 5.2.0.114 is only required on macOS/Darwin; other platforms just require 5.2.0. Update the `MonoAotOffsetsDumper.exe` invocation so that `mono --arch=32` is only used on macOS, *not* Linux. [0]: https://jenkins.mono-project.com/job/xamarin-anroid-linux-pr-builder/444/
jonpryor
added
the
full-mono-integration-build
jonpryor
pushed a commit
that referenced
this pull request
Mar 6, 2020
Changes: dotnet/java-interop@3dab5a0...9324e1e * dotnet/java-interop@9324e1e: [generator] Classes within interfaces naming (#592) * dotnet/java-interop@e557ba4: [generator] Allow multiple `generator --apiversions` (#593) * dotnet/java-interop@fa52a1c: [Java.Interop.Tools.JavaCallableWrappers] Renumber XA4213 to XA4217 (#594)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits 721c433, 469e628, and 986869b attempted to fix the macOS
Jenkins build by using
mono --arch=32/mono32to runMonoAotOffsetsDumper.exe, and by altering the mono version check torequire mono 5.2.0.114, which was needed in order for macOS to provide
the
mono32binary in a location included in$PATH.Those commits also broke the Linux+Jenkins build, by requiring
a binary (
mono32) that (1) doesn't exist on Linux, and (2) isn'tneeded on Linux (Linux requires a 64-bit process to invoke
MonoAotOffsetsDumper.exe!):Mono 5.2.0 is pre-installed on that machine, but not 5.2.0.114.
Update the mono version check so that 5.2.0.114 is only required on
macOS/Darwin; other platforms just require 5.2.0.
Update the
MonoAotOffsetsDumper.exeinvocation so thatmono --arch=32is only used on macOS, not Linux.