[Xamarin.Android.Build.Tests] Add support for testing on system applications. #5708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
force-pushed
the
fastdevsystemapp
branch
2 times, most recently
from
1087d13
to
28062ae
Compare
|
The nightly build has the new test and it passed https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4543632&view=results |
jonathanpeppers
approved these changes
Mar 10, 2021
dellis1972
force-pushed
the
fastdevsystemapp
branch
3 times, most recently
from
b81ea3e
to
41edce4
Compare
|
Some tests are failing because the emulator is disappearing half way through the test run... weird. |
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/DeviceTest.cs
Outdated
Show resolved
Hide resolved
dellis1972
force-pushed
the
fastdevsystemapp
branch
2 times, most recently
from
39c1c42
to
164d4e6
Compare
…cations. Context https://work.azdo.io/1288717 The new fast deployment system broke fast deployment for system installed applications. This commit adds unit tests to stop this kind of regression in the future. In order to install a `system` application we need a few things to happen 1. The emulator MUST be started with the `-system-writable` argument 2. The apk needs to be signed with a platform keystore. 3. The AndroidManifest must include `android:sharedUserId="android.uid.system"` in its `manifest` element.
dellis1972
force-pushed
the
fastdevsystemapp
branch
from
cef0d9f
to
d442874
Compare
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Mar 29, 2021
…cations. (dotnet#5708) Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1288717 Context: xamarin/monodroid@83de4b4 Changes: xamarin/monodroid@b2a750a...4163ee9 * xamarin/monodroid@4163ee947: [Xamarin.Android.Build.Tasks] Support FastDev for System Apps (dotnet#1177) (dotnet#1186) * xamarin/monodroid@947c6ef72: Bump to xamarin/xamarin-android/d16-9@877f5727 (dotnet#1183) The new fast deployment system (xamarin/monodroid@767f6471) broke fast deployment for system-installed applications. This is fixed in xamarin/monodroid@4163ee94. Adds unit tests to stop this kind of regression in the future. In order to install a `system` application we need a few things: 1. The emulator MUST be started with the `-system-writable` argument 2. The `.apk` needs to be signed with a platform keystore, found at: https://github.com/aosp-mirror/platform_build/tree/master/target/product/security 3. `AndroidManifest.xml` must set [`/manifest/@android:sharedUserId`][0] to `android.uid.system`: <manifest xmlns:android="http://schemas.android.com/apk/res/android" android:sharedUserId="android.uid.system" …> </manifest> See also: * https://medium.com/xrpractices/android-system-apps-development-d73bedfb8def [0]: https://developer.android.com/guide/topics/manifest/manifest-element#uid
jonpryor
pushed a commit
that referenced
this pull request
Mar 30, 2021
…cations. (#5708) Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1288717 Context: xamarin/monodroid@83de4b4 Changes: xamarin/monodroid@b2a750a...4163ee9 * xamarin/monodroid@4163ee947: [Xamarin.Android.Build.Tasks] Support FastDev for System Apps (#1177) (#1186) * xamarin/monodroid@947c6ef72: Bump to xamarin/xamarin-android/d16-9@877f5727 (#1183) The new fast deployment system (xamarin/monodroid@767f6471) broke fast deployment for system-installed applications. This is fixed in xamarin/monodroid@4163ee94. Adds unit tests to stop this kind of regression in the future. In order to install a `system` application we need a few things: 1. The emulator MUST be started with the `-system-writable` argument 2. The `.apk` needs to be signed with a platform keystore, found at: https://github.com/aosp-mirror/platform_build/tree/master/target/product/security 3. `AndroidManifest.xml` must set [`/manifest/@android:sharedUserId`][0] to `android.uid.system`: <manifest xmlns:android="http://schemas.android.com/apk/res/android" android:sharedUserId="android.uid.system" …> </manifest> See also: * https://medium.com/xrpractices/android-system-apps-development-d73bedfb8def [0]: https://developer.android.com/guide/topics/manifest/manifest-element#uid
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1288717
The new fast deployment system broke fast deployment for system installed
applications. This commit adds unit tests to stop this kind of regression
in the future.
In order to install a
systemapplication we need a few things to happen-writable-systemargumentandroid:sharedUserId="android.uid.system"in its
manifestelement.platformkeys at https://github.com/aosp-mirror/platform_build/tree/master/target/product/security