[Xamarin.ProjectTools] Always ref Microsoft.Build.Engine #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@borgdylan is reporting that xamarin-android isn't building for him with a more recent mono/master build, because the `Microsoft.Build.BuildEngine` namespace can't be resolved, because the `Microsoft.Build.Engine.dll` assembly isn't being referenced. `Microsoft.Build.Engine.dll` isn't being referenced because it's Conditional so that it's only referenced on Windows. I don't know why this is conditional to Windows, but `Microsoft.Build.Engine.dll` exists *now*, so always use it.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Dec 19, 2019
Changes: dotnet/java-interop@f3553f4...d61b329 * dotnet/java-interop@d61b329 [Java.Interop-Tests] Relax Exception.Message checks (dotnet#544) * dotnet/java-interop@d778204 [Java.Interop] Better linker-friendly JavaObjectArray<T>.ValueMarshaler (dotnet#546) * dotnet/java-interop@4bd07e0 [vs-code] Recommend the zbecknell.t4-support extension (dotnet#545) * dotnet/java-interop@3b24a2c [Java.Interop] apply AggressiveInlining where profiler shows calls (dotnet#541)
jonpryor
added a commit
that referenced
this pull request
Dec 20, 2019
Changes: dotnet/java-interop@f3553f4...d61b329 * dotnet/java-interop@d61b329 [Java.Interop-Tests] Relax Exception.Message checks (#544) * dotnet/java-interop@d778204 [Java.Interop] Better linker-friendly JavaObjectArray<T>.ValueMarshaler (#546) * dotnet/java-interop@4bd07e0 [vs-code] Recommend the zbecknell.t4-support extension (#545) * dotnet/java-interop@3b24a2c [Java.Interop] apply AggressiveInlining where profiler shows calls (#541)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@borgdylan is reporting that xamarin-android isn't building for him
with a more recent mono/master build, because the
Microsoft.Build.BuildEnginenamespace can't be resolved, because theMicrosoft.Build.Engine.dllassembly isn't being referenced.Microsoft.Build.Engine.dllisn't being referenced because it'sConditional so that it's only referenced on Windows.
I don't know why this is conditional to Windows, but
Microsoft.Build.Engine.dllexists now, so always use it.