[tests] Clear adb log after running the test #5164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure we don't get activity displayed message from previous run. `WaitForActivityToStart` doesn't know the `PID`, so it can match previous run. I was curious why CI test run doesn't show crash I see when running manualy on hardware device. Let see whether it will catch it with this change.
This way it should be cleared after every test and we will not potentialy loose logcat output of emulator startup in the first test run on fresh started emulator.
radekdoulik
requested review from
dellis1972 and
jonathanpeppers
as code owners
dellis1972
approved these changes
Sep 30, 2020
radekdoulik
changed the title
jonathanpeppers
approved these changes
Sep 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sure we don't get activity displayed message from previous run.
WaitForActivityToStartdoesn't know thePID, so it can match theprevious run.
I was curious why CI test run doesn't show the crash I see when running
manualy on hardware device. Let see whether it will catch it with this
change.
Update: it works and the tests fails now as it should. Opened issue
#5166,
which should be fixed by
#5145