[Xamarin.Android.Build.Tasks] Fix <InstallAndroidDependencies/> #4969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcollins
force-pushed
the
auto-install-sdk
branch
from
b7b1b90 to
250d3fb
Compare
pjcollins
changed the title
pjcollins
force-pushed
the
auto-install-sdk
branch
from
250d3fb to
7852b2d
Compare
Member
Author
|
The only failure against the latest changes looks unrelated: I think we'll wait for #4960 to land before this. |
Context: xamarin/android-sdk-installer#450 A fix for the `<InstallAndroidDependencies/>` target has been brought in via the `android-sdk-installer` bump in xamarin/monodroid@b12a3e8d. The `<InstallAndroidDependencies/>` test previously had issues due to clean up logic in the test framework that partially deleted the newly provisioned Android SDK on a subsequent build. I believe that we've been seeing successful results for this test because the subsequent build in the test would fall back to a different Android SDK that was already on disk. The test has been improved by asserting that the newly installed Android SDK is used during the subsequent build.
pjcollins
force-pushed
the
auto-install-sdk
branch
from
24d281e to
5ed52b3
Compare
pjcollins
changed the title
pjcollins
changed the title
pjcollins
changed the title
Contributor
Context: https://github.com/xamarin/android-sdk-installer/commit/2b4d1a6a4c49c3bc3fc9751726d854d75c617434
Changes: https://github.com/xamarin/monodroid/compare/5784a746...b12a3e8d
* xamarin/monodroid@b12a3e8d5: Bump to xamarin/android-sdk-installer/master@2b4d1a6 & xamarin/xamarin-android/master@d583b7c (#1107)
* xamarin/monodroid@3d84feddd: Bump to xamarin/xamarin-android/master@f0d565fe (#1106)
* xamarin/monodroid@ec2931825: Bump to xamarin/android-sdk-installer/master@c6c12db0 (#1105)
Sometimes, `<InstallAndroidDependencies/>` would fail when running on
Windows, a'la:
…\Xamarin\Android\Xamarin.Installer.Common.targets(12,3): Cannot access a disposed object.
Object name: 'SslStream'.
A fix for the `ObjectDisposedException` has been brought in via the
`android-sdk-installer` bump in xamarin/monodroid@b12a3e8d.
The `<InstallAndroidDependencies/>` test previously had issues due to
clean up logic in the test framework that partially deleted the newly
provisioned Android SDK on a subsequent build. I believe that we've
been seeing successful results for this test because the subsequent
build in the test would fall back to a different Android SDK that was
already on disk. The test has been improved by asserting that the
newly installed Android SDK is used during the subsequent build. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: xamarin/android-sdk-installer#450
Changes: https://github.com/xamarin/android-sdk-installer/compare/c6c12db0...2b4d1a6
Changes: https://github.com/xamarin/monodroid/compare/5784a746...b12a3e8d
A fix for the
<InstallAndroidDependencies/>target has been brought invia the
android-sdk-installerbump in xamarin/monodroid@b12a3e8.The
<InstallAndroidDependencies/>test previously had issues due toclean up logic in the test framework that partially deleted the newly
provisioned Android SDK on a subsequent build. I believe that we've
been seeing successful results for this test because the subsequent
build in the test would fall back to a different Android SDK that was
already on disk. The test has been improved by asserting that the newly
installed Android SDK is used during the subsequent build.