[bundletool] bump to 0.10.0 #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://github.com/google/bundletool/releases/tag/0.10.0 Context: https://mvnrepository.com/artifact/com.android.tools.build/bundletool `bundletool` has had a few releases lately, we should update the version we are shipping with Xamarin.Android. I also noticed we were shipping: bundletool-all-0.8.0-jar I think we could just use `bundletool.jar`. It would be useful to have a static filename as versions change release to release. This matches up with other things we ship, such as `r8.jar`. You can query the version of `bundletool` with: $ java -jar bundletool.jar version 0.10.0 So we don't need to encode the version in the filename.
dellis1972
approved these changes
Jul 3, 2019
jonpryor
pushed a commit
that referenced
this pull request
Jul 22, 2019
Context: https://github.com/google/bundletool/releases/tag/0.10.0 Context: https://mvnrepository.com/artifact/com.android.tools.build/bundletool Context: https://ossmsft.visualstudio.com/_oss?requestId=1728210&_a=progress `bundletool` has had a few releases lately, we should update the version we are shipping with Xamarin.Android. I also noticed we were shipping: bundletool-all-0.8.0-jar I think we could just use `bundletool.jar`. It would be useful to have a static filename as versions change release to release. This matches up with other things we ship, such as `r8.jar`. You can query the version of `bundletool` with: $ java -jar bundletool.jar version 0.10.0 So we don't need to encode the version in the filename.
jonpryor
pushed a commit
that referenced
this pull request
Jul 22, 2019
Context: https://github.com/google/bundletool/releases/tag/0.10.0 Context: https://mvnrepository.com/artifact/com.android.tools.build/bundletool Context: https://ossmsft.visualstudio.com/_oss?requestId=1728210&_a=progress `bundletool` has had a few releases lately, we should update the version we are shipping with Xamarin.Android. I also noticed we were shipping: bundletool-all-0.8.0-jar I think we could just use `bundletool.jar`. It would be useful to have a static filename as versions change release to release. This matches up with other things we ship, such as `r8.jar`. You can query the version of `bundletool` with: $ java -jar bundletool.jar version 0.10.0 So we don't need to encode the version in the filename.
jonpryor
added a commit
that referenced
this pull request
Jul 22, 2019
This reverts commit ea13bec. Oops; this was to be applied to d16-3, not d16-2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/google/bundletool/releases/tag/0.10.0
Context: https://mvnrepository.com/artifact/com.android.tools.build/bundletool
bundletoolhas had a few releases lately, we should update theversion we are shipping with Xamarin.Android.
I also noticed we were shipping:
I think we could just use
bundletool.jar. It would be useful to havea static filename as versions change release to release. This matches
up with other things we ship, such as
r8.jar.You can query the version of
bundletoolwith:So we don't need to encode the version in the filename.