[build] Do not build obsolete Mono.Android assemblies #2469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
added
the
full-mono-integration-build
jonpryor
requested review from
dellis1972 and
jonathanpeppers
as code owners
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
macOS PR Debug Build failure is because the |
Context: dotnet#1032 We previously obsoleted support for API levels earlier than API-19; see commit 66e1b65. Next up: stop *building* `Mono.Android.dll` and related assemblies for API levels earlier than API-19, and stop *shipping* `Mono.Android.dll` assemblies for `$(TargetFrameworkVersion)` values before `v4.4` (19). PR dotnet#1032 previously tried to do this, and failed, because it attempted to do "too much," removing code from `Mono.Android.dll` *as well as* removing support for *building* the obsolete API levels. Simplify things by *just* altering the build system and *not* the source code within `Mono.Android.dll`.
jonpryor
force-pushed
the
jonp-do-not-build-obsolete-bindings
branch
from
01ca136 to
bd4da9d
Compare
dellis1972
approved these changes
Nov 30, 2018
jonathanpeppers
approved these changes
Nov 30, 2018
This was referenced Dec 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #1032
We previously obsoleted support for API levels earlier than API-19;
see commit 66e1b65.
Next up: stop building
Mono.Android.dlland related assemblies forAPI levels earlier than API-19, and stop shipping
Mono.Android.dllassemblies for
$(TargetFrameworkVersion)values beforev4.4(19).PR #1032 previously tried to do this, and failed, because it attempted
to do "too much," removing code from
Mono.Android.dllas well asremoving support for building the obsolete API levels.
Simplify things by just altering the build system and not the
source code within
Mono.Android.dll.