[Xamarin.Android.Build.Tasks] target to simplify @(FileWrites) #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our "MSBuild Best Practices" guide, the convention for using a
"stamp" file has a bit of boilerplate...
<Target Name="_MyTarget"
Inputs="..."
Outputs="$(_AndroidStampDirectory)_MyTarget.stamp">
<!--...-->
<Touch Files="$(_AndroidStampDirectory)_MyTarget.stamp" AlwaysCreate="True" />
<ItemGroup>
<FileWrites Include="$(_AndroidStampDirectory)_MyTarget.stamp" />
</ItemGroup>
</Target>
It would be reasonably easy to mess this up.
If we add a new `_AddFilesToFileWrites` target that automatically adds
`$(_AndroidStampDirectory)*.stamp` to `FileWrites`, we can simplify
things:
<Target Name="_MyTarget"
Inputs="..."
Outputs="$(_AndroidStampDirectory)_MyTarget.stamp">
<!--...-->
<Touch Files="$(_AndroidStampDirectory)_MyTarget.stamp" AlwaysCreate="True" />
</Target>
This should be less prone to mistakes.
|
I think all the failures here are on-device network tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our "MSBuild Best Practices" guide, the convention for using a
"stamp" file has a bit of boilerplate...
It would be reasonably easy to mess this up.
If we add a new
_AddFilesToFileWritestarget that automatically adds$(_AndroidStampDirectory)*.stamptoFileWrites, we can simplifythings:
This should be less prone to mistakes.