-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mono.Android] abstract-ify inconsistent android.webkit API. #1304
[Mono.Android] abstract-ify inconsistent android.webkit API. #1304
Conversation
This needs changes in xamarin-android-api-compatibility too. |
256b47c
to
a6faa34
Compare
As part of discussion at dotnet/android#1078 (comment) , we decided to make changes to those inconsistent methods that used to be virtual and then became abstract, to become abstract even in old API level. It is done at metadata fixup level. (copying the commitmsg from dotnet/android#1304)
a6faa34
to
bb9d123
Compare
As part of discussion at dotnet/android#1078 (comment) , we decided to make changes to those inconsistent methods that used to be virtual and then became abstract, to become abstract even in old API level. It is done at metadata fixup level. (copying the commitmsg from dotnet/android#1304)
build |
bb9d123
to
3082edb
Compare
As part of discussion at dotnet/android#1078 (comment) , we decided to make changes to those inconsistent methods that used to be virtual and then became abstract, to become abstract even in old API level. It is done at metadata fixup level. (copying the commitmsg from dotnet/android#1304)
As part of discussion at dotnet#1078 (comment) , we decided to make changes to those inconsistent methods that used to be virtual and then became abstract, to become abstract even in old API level. It is done at metadata fixup level.
3082edb
to
2eac2a5
Compare
As part of discussion at dotnet/android#1078 (comment) , we decided to make changes to those inconsistent methods that used to be virtual and then became abstract, to become abstract even in old API level. It is done at metadata fixup level. (copying the commitmsg from dotnet/android#1304)
I think these changes are too aggressive. The listed changes: <h2>Namespace Android.Webkit</h2>
<!-- start type WebHistoryItem --> <div>
<h3>Type Changed: Android.Webkit.WebHistoryItem</h3>
<p>Modified properties:</p>
<pre>
<div data-is-breaking> public <span class='added added-breaking-inline'>abstract</span> int Id { get; }
</div></pre> This turns
So why was this method changed at all? <h3>Type Changed: Android.Webkit.WebSettings</h3>
<p>Modified properties:</p>
<pre>
<div data-is-breaking> public <span class='added added-breaking-inline'>abstract</span> bool NavDump { get; set; }
</div><div data-is-breaking> public <span class='added added-breaking-inline'>abstract</span> bool PluginsEnabled { get; set; }
</div><div data-is-breaking> public <span class='added added-breaking-inline'>abstract</span> string PluginsPath { get; set; }
</div><div data-is-breaking> public <span class='added added-breaking-inline'>abstract</span> bool UseDoubleTree { get; set; }
</div><div data-is-breaking> public <span class='added added-breaking-inline'>abstract</span> bool UseWebViewBackgroundForOverscrollBackground { get; set; }
</div><div data-is-breaking> public <span class='added added-breaking-inline'>abstract</span> int UserAgent { get; set; }
</div></pre>
<p>Modified methods:</p>
<pre>
<div data-is-breaking> public <span class='added added-breaking-inline'>abstract</span> WebSettings.TextSize GetTextSize ()
</div></pre> These changes are in the same boat: WebSettings does not declare any of the methods In API-16 -- the last API level they appeared in -- none of those methods are Thus, why are we turning these deprecated and no longer public members into |
Regarding our previous discussion:
My interpretation of this was that if a member was I agree with my interpretation. For example, consider This PR does not fit the above description, not in my mind. This PR is turning methods which were always non- As such, this PR would make our binding worse: anybody deriving from |
huh, I am confused. With the latest |
The probable reason that |
As part of discussion at #1078 (comment) ,
we decided to make changes to those inconsistent methods that used to be
virtual and then became abstract, to become abstract even in old API level.
It is done at metadata fixup level.