Remove redundant null-forgiving operator on cts in Program.cs - #12190
Merged
jonathanpeppers merged 2 commits intoJul 21, 2026
Conversation
5 tasks
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix redundant null-forgiving operator on
Remove redundant null-forgiving operator on Jul 21, 2026
cts! in Program.cscts in Program.cs
3 tasks
jonathanpeppers
marked this pull request as ready for review
July 21, 2026 13:31
jonathanpeppers
enabled auto-merge (squash)
July 21, 2026 13:32
jonathanpeppers
approved these changes
Jul 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unnecessary null-forgiving operator in Microsoft.Android.Run where cts is already a non-nullable CancellationTokenSource initialized at declaration, aligning the code with the repo’s “never use !” guidance.
Changes:
- Replace
cts!.Token.IsCancellationRequestedwithcts.Token.IsCancellationRequestedin the logcat/app-exit wait loop.
dalexsoto
approved these changes
Jul 21, 2026
jonathanpeppers
deleted the
copilot/fix-redundant-null-forgiving-operator
branch
July 21, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctsinsrc/Microsoft.Android.Run/Program.csis a non-nullableCancellationTokenSourceinitialized at declaration, making the!incts!.Tokenredundant and a violation of the repo's "never use!" rule.Change
src/Microsoft.Android.Run/Program.cs: Remove postfix!fromcts!.Token.IsCancellationRequested→cts.Token.IsCancellationRequested