[build] Set $(JI_MAX_JDK) for Java.Interop
#1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the `make prepare` step so that we pass `JI_MAX_JDK=8` to Java.Interop's `make prepare` step. This prevents us from using JDK 9 if it is installed on the machine. Internal VSTS builds are failing *seemingly* because JDK 9 is installed and used by default on the build machine, with `gradelw` bailing out with: Caused by: java.lang.NoClassDefFoundError: javax/xml/bind/annotation/XmlSchema This previously worked with JDK 8, so we're hoping that the use of JDK 9 is the cause, and by *excluding* JDK 9 from being used we'll be able to build on VSTS again.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Mar 23, 2021
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1290584 Fixes: dotnet#5710 Changes: xamarin/monodroid@75cf1a2...3a05726 * xamarin/monodroid@3a05726b8: [Xamarin.Android.Build.Tasks] Fix the MAX_COMMAND adb Error. (dotnet#1182) * xamarin/monodroid@83de4b43c: [Xamarin.Android.Build.Tasks] Support FastDev for System Apps (dotnet#1177) * xamarin/monodroid@02f19e057: Bump to xamarin/android-sdk-installer@6bf8527 (dotnet#1176)
jonpryor
added a commit
that referenced
this pull request
Mar 24, 2021
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1290584 Fixes: #5710 Changes: xamarin/monodroid@75cf1a2...3a05726 * xamarin/monodroid@3a05726b8: [Xamarin.Android.Build.Tasks] Fix the MAX_COMMAND adb Error. (#1182) * xamarin/monodroid@83de4b43c: [Xamarin.Android.Build.Tasks] Support FastDev for System Apps (#1177) * xamarin/monodroid@02f19e057: Bump to xamarin/android-sdk-installer@6bf8527 (#1176)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
make preparestep so that we passJI_MAX_JDK=8toJava.Interop's
make preparestep. This prevents us from using JDK 9if it is installed on the machine.
Internal VSTS builds are failing seemingly because JDK 9 is
installed and used by default on the build machine, with
gradelwbailing out with:
This previously worked with JDK 8, so we're hoping that the use of
JDK 9 is the cause, and by excluding JDK 9 from being used we'll be
able to build on VSTS again.