[Mono.Android] Bind and enumify API-35 (#9043)

Context: https://developer.android.com/about/versions/15
Context: https://android-developers.googleblog.com/2024/06/the-third-beta-of-android-15.html

Context: xamarin/android-sdk-installer@785c9f7

Android 15 Developer Preview 3 has been released.

  * [API diff vs. API-34][0]
  * [API diff vs. API-VanillaIceCream Beta 2][1] (c993dee)
    
The Android 15 Developer Preview Program Overview
[Timeline and updates][2] section suggests the following timeline:

  * Feb/Mar: Developer Previews
  * April/May: Unstable Betas
  * June/July: Stable Betas
  * ???: Final

Additionally, enumify and mark API-35 as "stable", which changes
`net9.0-android` to default to `net9.0-android35`.

Notes:

  - The `Xamarin` component manifest is in the process of being
    updated to contain API-35 components; see also
	xamarin/android-sdk-installer@785c9f75.  This change has not yet
	"flowed" to dotnet/android yet.  Consequently, our existing
	`AndroidDependenciesTests.InstallAndroidDependenciesTest()` unit
	test fails.

	Update the test to have a `xamarin_manifest_needs_updating` toggle
	set to `true`; while `true` it asserts that the test fails.
	
	Once the `Xamarin` manifest update makes it to dotnet/android,
	this test will fail and it will need to toggled to `false` so
	that the normal checks occur.

  - The MAUI tests fail because 2 APIs that it uses have been marked
    as `[Obsolete]` in API-35: `Path.ComputeBounds(RectF, bool)` and
	`Window.SetStatusBarColor(Color)`.
	
	MAUI will need to change the API they use or suppress these
	"warnings as errors".

  - APICompat reports that several
    `[Android.Runtime.RequiresPermissionAttribute]` custom attributes
	have been removed.  As we do not consume this attribute, it does
	not cause any API breakage.

[0]: https://developer.android.com/sdk/api_diff/35/changes
[1]: https://developer.android.com/sdk/api_diff/35-incr/changes
[2]: https://developer.android.com/about/versions/15/overview

Configuration.Override.props.in

@@ -6,11 +6,11 @@
       kept consistent with each other, lest Bad Things Happen™
       -->
     <!-- The default Android API level to bind in src/Mono.Android -->
-    <AndroidApiLevel>34</AndroidApiLevel>
+    <AndroidApiLevel>35</AndroidApiLevel>
     <!-- The Xamarin.Android $(TargetFrameworkVersion) value that corresponds to $(AndroidApiLevel) -->
-    <AndroidFrameworkVersion>v14.0</AndroidFrameworkVersion>
+    <AndroidFrameworkVersion>v15.0</AndroidFrameworkVersion>
     <!-- The default Android API "id" that corresponds to $(AndroidApiLevel) -->
-    <AndroidPlatformId>34</AndroidPlatformId>
+    <AndroidPlatformId>35</AndroidPlatformId>
 
     <!--
       Colon-separated list of ABIs to build the mono JIT for.

Configuration.props

@@ -25,13 +25,13 @@
     <!-- The min API level supported by Microsoft.Android.Sdk -->
     <AndroidMinimumDotNetApiLevel Condition="'$(AndroidMinimumDotNetApiLevel)' == ''">21</AndroidMinimumDotNetApiLevel>
     <!-- *Latest* *stable* API level binding that we support; used when building src/Xamarin.Android.Build.Tasks -->
-    <AndroidLatestStableApiLevel Condition="'$(AndroidLatestStableApiLevel)' == ''">34</AndroidLatestStableApiLevel>
+    <AndroidLatestStableApiLevel Condition="'$(AndroidLatestStableApiLevel)' == ''">35</AndroidLatestStableApiLevel>
     <AndroidLatestStablePlatformId Condition="'$(AndroidLatestStablePlatformId)' == ''">$(AndroidLatestStableApiLevel)</AndroidLatestStablePlatformId>
-    <AndroidLatestStableFrameworkVersion Condition="'$(AndroidLatestStableFrameworkVersion)'==''">v14.0</AndroidLatestStableFrameworkVersion>
+    <AndroidLatestStableFrameworkVersion Condition="'$(AndroidLatestStableFrameworkVersion)'==''">v15.0</AndroidLatestStableFrameworkVersion>
     <!-- *Latest* *unstable* API level binding that we support; this can be the same as *stable* -->
-    <AndroidLatestUnstableApiLevel Condition="'$(AndroidLatestUnstableApiLevel)' == ''">35</AndroidLatestUnstableApiLevel>
-    <AndroidLatestUnstablePlatformId Condition="'$(AndroidLatestUnstablePlatformId)' == ''">VanillaIceCream</AndroidLatestUnstablePlatformId>
-    <AndroidLatestUnstableFrameworkVersion Condition="'$(AndroidLatestUnstableFrameworkVersion)'==''">v14.0.99</AndroidLatestUnstableFrameworkVersion>
+    <AndroidLatestUnstableApiLevel Condition="'$(AndroidLatestUnstableApiLevel)' == ''">$(AndroidLatestStableApiLevel)</AndroidLatestUnstableApiLevel>
+    <AndroidLatestUnstablePlatformId Condition="'$(AndroidLatestUnstablePlatformId)' == ''">$(AndroidLatestStablePlatformId)</AndroidLatestUnstablePlatformId>
+    <AndroidLatestUnstableFrameworkVersion Condition="'$(AndroidLatestUnstableFrameworkVersion)'==''">$(AndroidLatestStableFrameworkVersion)</AndroidLatestUnstableFrameworkVersion>
     <!-- The default API level used for $(TargetPlatformVersion) -->
     <AndroidDefaultTargetDotnetApiLevel Condition=" '$(AndroidDefaultTargetDotnetApiLevel)' == '' ">$(AndroidLatestStableApiLevel)</AndroidDefaultTargetDotnetApiLevel>
     <!-- The API level and TargetFrameworkVersion for the default Mono.Android.dll build -->

Directory.Build.props

@@ -35,7 +35,7 @@
          * Major/Minor match Android stable API level, such as 30.0 for API 30.
          * Bump first digit of the patch version for feature releases (and reset the first two digits to 0)
     -->
-    <AndroidPackVersion>34.99.0</AndroidPackVersion>
+    <AndroidPackVersion>35.0.0</AndroidPackVersion>
     <AndroidPackVersionSuffix>preview.7</AndroidPackVersionSuffix>
   </PropertyGroup>
 

build-tools/Xamarin.Android.Tools.BootstrapTasks/Xamarin.Android.Tools.BootstrapTasks/CheckApiCompatibility.cs

@@ -32,7 +32,7 @@ public sealed class CheckApiCompatibility : Task
 			{ "v12.1", "v12.0" },
 			{ "v13.0", "v12.1" },
 			{ "v14.0", "v13.0" },
-			{ "v14.0.99", "v14.0" },
+			{ "v15.0", "v14.0" },
 		};
 
 		static readonly string assemblyToValidate = "Mono.Android.dll";
@@ -70,7 +70,6 @@ public sealed class CheckApiCompatibility : Task
 		public override bool Execute ()
 		{
 			Log.LogMessage (MessageImportance.High, $"CheckApiCompatibility for ApiLevel: {ApiLevel}");
-			Log.LogWarning ($"# jonp: TargetFramework={TargetFramework}");
 
 			// Check to see if Api has a previous Api defined.
 			if (!api_versions.TryGetValue (ApiLevel, out string previousApiLevel)) {

build-tools/api-merge/merge-configuration.xml

@@ -23,9 +23,9 @@
     <File Path="api-32.xml.in" Level="32" />
     <File Path="api-33.xml.in" Level="33" />
     <File Path="api-34.xml.in" Level="34" />
-    <File Path="api-VanillaIceCream.xml.in" Level="35" />
+    <File Path="api-35.xml.in" Level="35" />
   </Inputs>
   <Outputs>
-    <File Path="api-VanillaIceCream.xml" LastLevel="35" />
+    <File Path="api-35.xml" LastLevel="35" />
   </Outputs>
 </Configuration>

build-tools/automation/yaml-templates/variables.yaml

@@ -51,7 +51,7 @@ variables:
 - name: IsRelOrTargetingRel
   value: $[or(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), startsWith(variables['System.PullRequest.TargetBranch'], 'release/'))]
 - name: DefaultTestSdkPlatforms  # Comma-separated SDK Platform(s) to install on test agents (no spaces)
-  value: 34,VanillaIceCream
+  value: 35
 - name: ExcludedNightlyNUnitCategories
   value: 'cat != SystemApplication & cat != TimeZoneInfo & cat != Localization'
 - name: RunMAUITestJob

build-tools/xaprepare/xaprepare/ConfigAndData/BuildAndroidPlatforms.cs

@@ -45,7 +45,7 @@ class BuildAndroidPlatforms
 			new AndroidPlatform (apiName: "Sv2",                    apiLevel: 32, platformID: "32",  include: "v12.1"),
 			new AndroidPlatform (apiName: "Tiramisu",               apiLevel: 33, platformID: "33",  include: "v13.0",   framework: "v13.0"),
 			new AndroidPlatform (apiName: "UpsideDownCake",         apiLevel: 34, platformID: "34",  include: "v14.0",   framework: "v14.0"),
-			new AndroidPlatform (apiName: "VanillaIceCream",        apiLevel: 35, platformID: "VanillaIceCream",  include: "v14.0.99",   framework: "v14.0.99", stable: false),
+			new AndroidPlatform (apiName: "VanillaIceCream",        apiLevel: 35, platformID: "35",  include: "v15.0",   framework: "v15.0"),
 		};
 
 	}

build-tools/xaprepare/xaprepare/ConfigAndData/Dependencies/AndroidToolchain.cs

@@ -70,8 +70,8 @@ public AndroidToolchain ()
 				new AndroidPlatformComponent ("platform-31_r01",   apiLevel: "31", pkgRevision: "1"),
 				new AndroidPlatformComponent ("platform-32_r01",   apiLevel: "32", pkgRevision: "1"),
 				new AndroidPlatformComponent ("platform-33-ext3_r03",   apiLevel: "33", pkgRevision: "3"),
-				new AndroidPlatformComponent ("platform-34-ext7_r02",   apiLevel: "34", pkgRevision: "2", isLatestStable: true),
-				new AndroidPlatformComponent ("platform-VanillaIceCream_r04",   apiLevel: "VanillaIceCream", pkgRevision: "4", isLatestStable: true),
+				new AndroidPlatformComponent ("platform-34-ext7_r02",   apiLevel: "34", pkgRevision: "2"),
+				new AndroidPlatformComponent ("platform-35_r01",   apiLevel: "35", pkgRevision: "1", isLatestStable: true),
 
 				new AndroidToolchainComponent ("sources-34_r01",
 					destDir: Path.Combine ("sources", "android-34"),

src/Mono.Android/Android.Net.Wifi.P2p/WifiP2pManager.cs

@@ -0,0 +1,17 @@
+using System;
+using Android.Runtime;
+
+namespace Android.Net.Wifi.P2p
+{
+	// This was converted to an enum in .NET 9
+	partial class WifiP2pManager
+	{
+		// Metadata.xml XPath field reference: path="/api/package[@name='android.net.wifi.p2p']/class[@name='WifiP2pManager']/field[@name='WIFI_P2P_DISCOVERY_STARTED']"
+		[Register ("WIFI_P2P_DISCOVERY_STARTED")]
+		public const int WifiP2pDiscoveryStarted = (int) 2;
+
+		// Metadata.xml XPath field reference: path="/api/package[@name='android.net.wifi.p2p']/class[@name='WifiP2pManager']/field[@name='WIFI_P2P_DISCOVERY_STOPPED']"
+		[Register ("WIFI_P2P_DISCOVERY_STOPPED")]
+		public const int WifiP2pDiscoveryStopped = (int) 1;
+	}
+}

src/Mono.Android/Mono.Android.csproj

@@ -91,6 +91,7 @@
     <Compile Include="Android.Icu\ListFormatter.cs" />
     <Compile Include="Android.Icu\RelativeDateTimeFormatter.cs" />
     <Compile Include="Android.Icu\DateIntervalFormat.cs" />
+    <Compile Include="Android.Net.Wifi.P2p\WifiP2pManager.cs" />
     <Compile Include="Android.Runtime\DynamicMethodNameCounter.cs" />
     <Compile Include="Android.Runtime\IJavaObjectValueMarshaler.cs" />
     <Compile Include="Android.Telecom\InCallService.cs" />