Skip to content

Commit

Permalink
[build] Don't set $(ImplicitlyExpandDesignTimeFacades)=False
Browse files Browse the repository at this point in the history
Way back in the dawn of two months ago and creating
`Mono.Android.csproj` by squinting *just right* and using the original
Makefiles as a guide (xbuild? what's that?), I saw that the "system"
`System.Runtime.dll` was being pulled in and I said: "wait...what?"

I mean, I asked "why is this using the *system* `System.Runtime.dll`
and not using the one that we just build and installed into
`bin/$(Configuration)/lib/xbuild-frameworks/MonoAndroid/v1.0/Facades`?"

On the assumption that *of course* I want to be using the
`System.Runtime.dll` that was previously built, I set
`$(ImplicitlyExpandDesignTimeFacades)` to False so that I could
explicitly list the one we just built instead of the system one.

This *works*...

However, copying that idiom elsewhere results in "bizarre" errors such
as that mentioned in commit 9a50c66:

	CSC: error CS1703: An assembly `System.Runtime' with the same identity
	has already been imported. Consider removing one of the references.

Setting `$(ImplicitlyExpandDesignTimeFacades)` to False isn't
required, and it's presence leads to mistakenly reusing the idiom
elsewhere. Remove it.
  • Loading branch information
jonpryor committed Jun 9, 2016
1 parent 474dc74 commit b40b022
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 21 deletions.
7 changes: 0 additions & 7 deletions src/Mono.Android.Export/Mono.Android.Export.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,6 @@
<HintPath>$(OutputPath)..\v1.0\Java.Interop.dll</HintPath>
<Private>False</Private>
</Reference>
<Reference Include="System.Runtime">
<HintPath>$(OutputPath)..\v1.0\Facades\System.Runtime.dll</HintPath>
<Private>False</Private>
</Reference>
</ItemGroup>
<ItemGroup>
<Compile Include="Properties\AssemblyInfo.cs" />
Expand Down Expand Up @@ -110,9 +106,6 @@
<Compile Include="Mono.CodeGeneration\Exp.cs" />
</ItemGroup>
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
<PropertyGroup>
<ImplicitlyExpandDesignTimeFacades>False</ImplicitlyExpandDesignTimeFacades>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\Mono.Android\Mono.Android.csproj">
<Project>{66CF299A-CE95-4131-BCD8-DB66E30C4BF7}</Project>
Expand Down
7 changes: 0 additions & 7 deletions src/Mono.Android/Mono.Android.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@
<HintPath>$(OutputPath)..\v1.0\Java.Interop.dll</HintPath>
<Private>False</Private>
</Reference>
<Reference Include="System.Runtime">
<HintPath>$(OutputPath)..\v1.0\Facades\System.Runtime.dll</HintPath>
<Private>False</Private>
</Reference>
</ItemGroup>
<ItemGroup>
<Compile Include="Android\IncludeAndroidResourcesFromAttribute.cs" />
Expand Down Expand Up @@ -302,9 +298,6 @@
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
<Import Project="Mono.Android.targets" />
<Import Project="$(IntermediateOutputPath)android-$(AndroidApiLevel)\Mono.Android.projitems" Condition="Exists('$(IntermediateOutputPath)android-$(AndroidApiLevel)\Mono.Android.projitems')" />
<PropertyGroup>
<ImplicitlyExpandDesignTimeFacades>False</ImplicitlyExpandDesignTimeFacades>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\build-tools\api-merge\api-merge.csproj">
<Project>{3FC3E78B-F7D4-42EA-BBE8-4535DF42BFF8}</Project>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@
<HintPath>$(OutputPath)..\v1.0\Java.Interop.dll</HintPath>
<Private>False</Private>
</Reference>
<Reference Include="System.Runtime">
<HintPath>$(OutputPath)..\v1.0\Facades\System.Runtime.dll</HintPath>
<Private>False</Private>
</Reference>
</ItemGroup>
<ItemGroup>
<Compile Include="Resources\Resource.designer.cs" />
Expand Down Expand Up @@ -348,9 +344,6 @@
<AndroidResource Include="Resources\layout\test_suite.axml" />
</ItemGroup>
<Import Project="$(OutputPath)\..\..\..\xbuild\Xamarin\Android\Xamarin.Android.CSharp.targets" />
<PropertyGroup>
<ImplicitlyExpandDesignTimeFacades>False</ImplicitlyExpandDesignTimeFacades>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\Mono.Android\Mono.Android.csproj">
<Project>{66CF299A-CE95-4131-BCD8-DB66E30C4BF7}</Project>
Expand Down

0 comments on commit b40b022

Please sign in to comment.