-
Notifications
You must be signed in to change notification settings - Fork 528
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[build] Don't set
$(ImplicitlyExpandDesignTimeFacades)
=False
Way back in the dawn of two months ago and creating `Mono.Android.csproj` by squinting *just right* and using the original Makefiles as a guide (xbuild? what's that?), I saw that the "system" `System.Runtime.dll` was being pulled in and I said: "wait...what?" I mean, I asked "why is this using the *system* `System.Runtime.dll` and not using the one that we just build and installed into `bin/$(Configuration)/lib/xbuild-frameworks/MonoAndroid/v1.0/Facades`?" On the assumption that *of course* I want to be using the `System.Runtime.dll` that was previously built, I set `$(ImplicitlyExpandDesignTimeFacades)` to False so that I could explicitly list the one we just built instead of the system one. This *works*... However, copying that idiom elsewhere results in "bizarre" errors such as that mentioned in commit 9a50c66: CSC: error CS1703: An assembly `System.Runtime' with the same identity has already been imported. Consider removing one of the references. Setting `$(ImplicitlyExpandDesignTimeFacades)` to False isn't required, and it's presence leads to mistakenly reusing the idiom elsewhere. Remove it.
- Loading branch information
Showing
3 changed files
with
0 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters