Skip to content

Commit

Permalink
[Xamarin.Android.Build.Tasks] fakeLogOpen is ignorable (#1463)
Browse files Browse the repository at this point in the history
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/585941

Commit 42a4b9b special-cased the `fakeLogOpen` messages to produce
warnings, instead of their earlier behavior of producing *errors*.

This was an improvement, in that builds were now able to finish, but
now developers are being "spammed" with lots of warnings about
`fakeLogOpen`, which cannot be easily ignored.

Further special-case the `fakeLogOpen` messages so that instead of
producing warnings, we instead produce "normal" messages.
  • Loading branch information
jonpryor authored Mar 23, 2018
1 parent 029a8b4 commit a09a0d5
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/Xamarin.Android.Build.Tasks/Tasks/Aapt.cs
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,11 @@ protected void LogEventsFromTextOutput (string singleLine, MessageImportance mes
line = int.Parse (match.Groups["line"].Value) + 1;
var level = match.Groups["level"].Value.ToLowerInvariant ();
var message = match.Groups ["message"].Value;
if (message.Contains ("fakeLogOpen") || level.Contains ("warning")) {
if (message.Contains ("fakeLogOpen")) {
LogMessage (singleLine, MessageImportance.Normal);
return;
}
if (level.Contains ("warning")) {
LogWarning (singleLine);
return;
}
Expand Down

0 comments on commit a09a0d5

Please sign in to comment.