Skip to content

Commit

Permalink
Change wording a bit, include page size in the message
Browse files Browse the repository at this point in the history
  • Loading branch information
grendello committed Nov 27, 2024
1 parent 845e139 commit 1fab20c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/Xamarin.Android.Build.Tasks/Properties/Resources.resx
Original file line number Diff line number Diff line change
Expand Up @@ -1063,12 +1063,13 @@ To use a custom JDK path for a command line build, set the 'JavaSdkDirectory' MS
{1} - NuGet package version</comment>
</data>
<data name="XA0141" xml:space="preserve">
<value>NuGet package '{0}' version '{1}' contains a shared library '{2}' ({3}) which is not correctly aligned. See https://developer.android.com/guide/practices/page-sizes for more details</value>
<value>NuGet package '{0}' version '{1}' contains a shared library '{2}' ({3}) which is not aligned to the {4} byte boundary. Google will require such alignment in the future. See https://developer.android.com/guide/practices/page-sizes for more details</value>
<comment>The following is a literal name and should not be translated: NuGet
{0} - NuGet package id
{1} - NuGet package version
{2} - shared library file name
{3} - target architecture name
{4} - is an integer (size in bytes)
</comment>
</data>
<data name="XA4249" xml:space="preserve">
Expand Down
3 changes: 2 additions & 1 deletion src/Xamarin.Android.Build.Tasks/Utilities/ELFHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ static void AssertValidLibraryAlignment (TaskLoggingHelper log, uint pageSize, s
packageId,
packageVersion,
Path.GetFileName (path),
archName
archName,
pageSize
);
break;
}
Expand Down

0 comments on commit 1fab20c

Please sign in to comment.