Merged
Conversation
NiklasGustafsson
suggested changes
Dec 6, 2024
NiklasGustafsson
left a comment
NiklasGustafsson
left a comment
There was a problem hiding this comment.
Maybe I'm missing something, but I don't see what the fix is, unless the default LR is actually changed (but I think it's not).
ghost
reviewed
Dec 17, 2024
|
I'm assuming that change is based on this documentation: @alinpahontu2912 , would it be possible to add more information in the PR description for "what was wrong, what we've changed?" |
ghost
reviewed
Dec 17, 2024
ghost
reviewed
Dec 18, 2024
Member
Author
|
The results for the code submitted by the issue owner: #1417 (comment) are here: |
ghost
approved these changes
Dec 20, 2024
ghost
requested review from
ghost
approved these changes
Dec 20, 2024
NiklasGustafsson
approved these changes
Dec 20, 2024
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1417
Remove unnecesary max_step not zero check that modified the gradient. Based on algorithm here: https://pytorch.org/docs/stable/_modules/torch/optim/rprop.html#Rprop