Standardization of Event Source tracing + Improvements for readability - #484
Merged
Conversation
# Conflicts: # src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Wraith2
approved these changes
Mar 24, 2020
Wraith2
left a comment
Wraith2
left a comment
Contributor
There was a problem hiding this comment.
Other than the comments I noted it looks like just refactored names, so LGTM.
David-Engel
approved these changes
Mar 24, 2020
Member
Author
|
Enabling all traces seems to capture issues in Managed SNI tracing implementation from PR #461, to be continued tomorrow! |
JRahnama
approved these changes
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates in EventSource tracing implementation:
Also to mention:
End users would have to enable "ExecutionTrace" to continue to capture Begin/End execute commands.