Skip to content

Address AccessToken and SSPI review feedback - #4629

Merged
paulmedynski merged 1 commit into
mainfrom
dev/automation/address-pr-4561-feedback
Sep 3, 2026
Merged

Address AccessToken and SSPI review feedback#4629
paulmedynski merged 1 commit into
mainfrom
dev/automation/address-pr-4561-feedback

Address AccessToken authentication feedback

55f1d22
Select commit
Loading
Failed to load commit list.
Azure Pipelines / sqlclient-pr succeeded Sep 2, 2026 in 42m 55s

Build #24511 had test failures

0 errors / 1 warnings

Details

Tests

  • Failed: 3 (0.01%)
  • Passed: 33,423 (87.89%)
  • Other: 4,602 (12.10%)
  • Total: 38,028

Annotations

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.SqlCommandCancelTest.CancelAndDisposePreparedCommand_Tcp

See this annotation in the file changed.

@azure-pipelines azure-pipelines / sqlclient-pr

Microsoft.Data.SqlClient.ManualTesting.Tests.SqlCommandCancelTest.CancelAndDisposePreparedCommand_Tcp 

Microsoft.Data.SqlClient.SqlException : Transaction (Process ID 613) was deadlocked on lock resources with another process and has been chosen as the deadlock victim. Rerun the transaction.
Raw output 
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\SqlConnection.cs:line 2682
   at Microsoft.Data.SqlClient.Connection.SqlConnectionInternal.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\Connection\SqlConnectionInternal.cs:line 1281
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, SqlCommand command, Boolean callerHasConnectionLock, Boolean asyncClose) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\TdsParser.cs:line 1721
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\TdsParser.cs:line 3119
   at Microsoft.Data.SqlClient.SqlDataReader.TryHasMoreRows(Boolean& moreRows) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\SqlDataReader.cs:line 3280
   at Microsoft.Data.SqlClient.SqlDataReader.TryReadInternal(Boolean setTimeout, Boolean& more) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\SqlDataReader.cs:line 3579
   at Microsoft.Data.SqlClient.SqlDataReader.Read() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\SqlDataReader.cs:line 3532
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlCommandCancelTest.CancelAndDisposePreparedCommand(String constr) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\SqlCommand\SqlCommandCancelTest.cs:line 342
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlCommandCancelTest.CancelAndDisposePreparedCommand_Tcp() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\SqlCommand\SqlCommandCancelTest.cs:line 143
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.CertificateTest.OpeningConnectionWithNicTest

See this annotation in the file changed.

@azure-pipelines azure-pipelines / sqlclient-pr

Microsoft.Data.SqlClient.ManualTesting.Tests.CertificateTest.OpeningConnectionWithNicTest 

System.Exception : Could not generate certificate. Error output: Certificate folder path is: C:\Certificates


    Directory: C:\


Mode                 LastWriteTime         Length Name                                                                 
----                 -------------         ------ ----                                                                 
d-----          9/2/2026   6:34 PM                Certificates                                                         
Certificate created successfully
Certificate Thumbprint: 53FDE383451577AD01408B1C3897D3DE9BD5ED39


    Directory: C:\Certificates


Mode                 LastWriteTime         Length Name                                                                 
----                 -------------         ------ ----                                                                 
-a----          9/2/2026   6:34 PM            855 SQLClientSelfSignedCertificate.cer                                   

PSPath                   : Microsoft.PowerShell.Security\Certificate::LocalMachine\Root\53FDE383451577AD01408B1C3897D3D
                           E9BD5ED39
PSParentPath             : Microsoft.PowerShell.Security\Certificate::LocalMachine\Root
PSChildName              : 53FDE383451577AD01408B1C3897D3DE9BD5ED39
PSIsContainer            : False
Archived                 : False
Extensions               : {System.Security.Cryptography.Oid, System.Security.Cryptography.Oid, 
                           System.Security.Cryptography.Oid, System.Security.Cryptography.Oid}
FriendlyName             : 
IssuerName               : System.Security.Cryptography.X509Certificates.X500DistinguishedName
NotAfter                 : 9/2/2029 6:34:53 PM
NotBefore                : 9/2/2026 6:24:55 PM
HasPrivateKey            : False
PrivateKey               : 
PublicKey                : System.Security.Cryptography.X509Certificates.PublicKey
RawData                  : {48, 130, 3, 83...}
SerialNumber             : 1EA4774F1E9AED884A3D69C8EA463AEB
SubjectName              : System.Security.Cryptography.X509Certificates.X500DistinguishedName
SignatureAlgorithm       : System.Security.Cryptography.Oid
Thumbprint               : 53FDE383451577AD01408B1C3897D3DE9BD5ED39
Version                  : 3
Handle                   : 2772914996352
Issuer                   : CN=69fe7d9cc000001
Subject                  : CN=69fe7d9cc000001
EnhancedKeyUsageList     : {Server Authentication (1.3.6.1.5.5.7.3.1)}
DnsNameList              : {69fe7d9cc000001, localhost, SQLAliasName}
SendAsTrustedIssuer      : False
EnrollmentPolicyEndPoint : Microsoft.CertificateServices.Commands.EnrollmentEndPointProperty
EnrollmentServerEndPoint : Microsoft.CertificateServices.Commands.EnrollmentEndPointProperty
PolicyId                 :
Raw output 
   at Microsoft.Data.SqlClient.ManualTesting.Tests.CertificateTest.CreateValidCertificate(String script) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ConnectionTestWithSSLCert\CertificateTest.cs:line 234
   at Microsoft.Data.SqlClient.ManualTesting.Tests.CertificateTest..ctor() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ConnectionTestWithSSLCert\CertificateTest.cs:line 86
   at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions)

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.SqlCommandReliabilityTest.ConcurrentExecutionAsync

See this annotation in the file changed.

@azure-pipelines azure-pipelines / sqlclient-pr

Microsoft.Data.SqlClient.ManualTesting.Tests.SqlCommandReliabilityTest.ConcurrentExecutionAsync 

System.InvalidOperationException : Timeout expired.  The timeout period elapsed prior to obtaining a connection from the pool.  This may have occurred because all pooled connections were in use and max pool size was reached.
Raw output 
   at Microsoft.Data.Common.ADP.ExceptionWithStackTrace(Exception e) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\Common\AdapterUtil.cs:line 128
--- End of stack trace from previous location ---
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlCommandReliabilityTest.<>c__DisplayClass48_0.<<ProcessDataAsAsync>b__0>d.MoveNext() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\RetryLogic\SqlCommandReliabilityTest.cs:line 723
--- End of stack trace from previous location ---
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlCommandReliabilityTest.ProcessDataAsAsync(String cnnString, SqlRetryLogicBaseProvider provider, String query, Func`2 commandAction) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\RetryLogic\SqlCommandReliabilityTest.cs:line 738
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlCommandReliabilityTest.ConcurrentExecutionAsync(String cnnString, SqlRetryLogicBaseProvider provider) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\RetryLogic\SqlCommandReliabilityTest.cs:line 648
--- End of stack trace from previous location ---
View more details on Azure Pipelines