Skip to content

Fix fetching signature verification result from cache #4339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cheenamalhotra merged 3 commits into from
Jun 5, 2026
Merged

Fix fetching signature verification result from cache #4339

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f38b30
Fix fetching signature verification result from cache
cheenamalhotra Jun 4, 2026
4fd1470
Introduce Tri-State
cheenamalhotra Jun 4, 2026
d8f8b7a
Remove stale content, clean ups
cheenamalhotra Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SignatureVerificationCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ internal bool GetSignatureVerificationResult(string keyStoreName, string masterK

string cacheLookupKey = GetCacheLookupKey(masterKeyPath, allowEnclaveComputations, signature, keyStoreName);

return _cache.TryGetValue<bool>(cacheLookupKey, out bool value);
return _cache.TryGetValue<bool>(cacheLookupKey, out bool value) && value;
Comment thread
cheenamalhotra marked this conversation as resolved.
Outdated
}

/// <summary>
Expand Down
38 changes: 38 additions & 0 deletions ...ata.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/SignatureVerificationCacheTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System;
using Xunit;

namespace Microsoft.Data.SqlClient.UnitTests
{
public class SignatureVerificationCacheTests
Comment thread
paulmedynski marked this conversation as resolved.
{
[Fact]
public void GetSignatureVerificationResult_DoesNotTreatCachedFailureAsSuccess()
{
ColumnMasterKeyMetadataSignatureVerificationCache cache = ColumnMasterKeyMetadataSignatureVerificationCache.Instance;
string keyStoreName = $"TEST_PROVIDER_{Guid.NewGuid():N}";
string masterKeyPath = $"https://unit-test/{Guid.NewGuid():N}";
byte[] signature = [1, 2, 3, 4];

cache.AddSignatureVerificationResult(keyStoreName, masterKeyPath, allowEnclaveComputations: true, signature, result: false);

Assert.False(cache.GetSignatureVerificationResult(keyStoreName, masterKeyPath, allowEnclaveComputations: true, signature));
}

[Fact]
public void GetSignatureVerificationResult_ReturnsTrueForCachedSuccess()
{
ColumnMasterKeyMetadataSignatureVerificationCache cache = ColumnMasterKeyMetadataSignatureVerificationCache.Instance;
string keyStoreName = $"TEST_PROVIDER_{Guid.NewGuid():N}";
string masterKeyPath = $"https://unit-test/{Guid.NewGuid():N}";
byte[] signature = [4, 3, 2, 1];

cache.AddSignatureVerificationResult(keyStoreName, masterKeyPath, allowEnclaveComputations: true, signature, result: true);

Assert.True(cache.GetSignatureVerificationResult(keyStoreName, masterKeyPath, allowEnclaveComputations: true, signature));
}
}
}
Loading