Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1936,9 +1936,10 @@
if (s_diagnosticListener.IsEnabled(SqlClientConnectionOpenAfter.Name) ||
s_diagnosticListener.IsEnabled(SqlClientConnectionOpenError.Name))
{
result.Task.ContinueWith(

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View check run for this annotation

Azure Pipelines / PR-SqlClient-Project (Build Azure Package [Linux] Test Azure Package)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs#L1939

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs(1939,37): Error CS1501: No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View check run for this annotation

Azure Pipelines / PR-SqlClient-Project (Build Azure Package [Linux] Test Azure Package)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs#L1939

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs(1939,37): Error CS1501: No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp)

No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View check run for this annotation

Azure Pipelines / PR-SqlClient-Project (Build Azure Package [macOS] Test Azure Package)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs#L1939

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs(1939,37): Error CS1501: No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View check run for this annotation

Azure Pipelines / PR-SqlClient-Project (Build Azure Package [macOS] Test Azure Package)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs#L1939

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs(1939,37): Error CS1501: No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View check run for this annotation

Azure Pipelines / PR-SqlClient-Project (Build Azure Package [Linux Integration] Test Azure Package)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs#L1939

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs(1939,37): Error CS1501: No overload for method 'ContinueWith' takes 4 arguments

Check failure on line 1939 in src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs

View check run for this annotation

Azure Pipelines / PR-SqlClient-Project (Build Azure Package [Linux Integration] Test Azure Package)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs#L1939

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs(1939,37): Error CS1501: No overload for method 'ContinueWith' takes 4 arguments
continuationAction: s_openAsyncComplete,
state: operationId, // connection is passed in TaskCompletionSource async state
continuationOptions: TaskContinuationOptions.ExecuteSynchronously,
scheduler: TaskScheduler.Default
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,8 @@
<!-- to "Package". If this is not specified, the build will revert to default behavior of -->
<!-- referencing MDS via the project. -->
<ProjectReference Include="$(RepoRoot)src\Microsoft.Data.SqlClient\src\Microsoft.Data.SqlClient.csproj"
Condition="'$(ReferenceType)' != 'Package'" />
Condition="'$(ReferenceType)' != 'Package'"
Private="true" />
<PackageReference Include="Microsoft.Data.SqlClient"
Condition="'$(ReferenceType)' == 'Package'" />

Expand Down Expand Up @@ -422,4 +423,14 @@
<ProjectReference Include="$(TestsPath)tools/TDS/TDS.EndPoint/TDS.EndPoint.csproj" />
<ProjectReference Include="$(TestsPath)tools/TDS/TDS.Servers/TDS.Servers.csproj" />
</ItemGroup>

<!--
The SqlClient project uses a custom OutputPath (artifacts/...) which prevents the SDK's
GenerateBuildDependencyFile target from emitting a runtime entry in deps.json. Without a
runtime entry, 'dotnet exec - -depsfile' cannot resolve the assembly in child processes
(e.g. RemoteExecutor). Patch deps.json after generation to inject the missing entry.
-->
<Import Project="$(RepoRoot)tools/targets/PatchTestDeps.targets"
Condition="'$(ReferenceType)' != 'Package'" />

</Project>
Loading
Loading