Skip to content

Prevent scanning/signing of unrelated packages #4007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsharma2700 merged 5 commits into from
Mar 10, 2026
+50 −5
Merged

Prevent scanning/signing of unrelated packages #4007

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8057dd5
Prevent unrelated package signing
samsharma2700 Mar 5, 2026
b9398d5
Define download target path
samsharma2700 Mar 5, 2026
050ba04
Copy MDS nuget package
samsharma2700 Mar 10, 2026
2f952da
Merge branch 'main' of https://github.com/dotnet/SqlClient into dev/s…
samsharma2700 Mar 10, 2026
f2ec391
Add loggingArtifactsName parameter
samsharma2700 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,18 +98,19 @@ jobs:
- ${{ parameters.prebuildSteps }}

# If we're testing in Package mode, then we must download dependent package artifacts.
# Downloads go to packages/ (local NuGet source), not $(packagePath) (build output).
- ${{ if eq(parameters.referenceType, 'Package') }}:
- task: DownloadPipelineArtifact@2
displayName: Download Abstractions Package Artifacts
inputs:
artifactName: ${{ parameters.abstractionsArtifactsName }}
targetPath: $(packagePath)
targetPath: $(Build.SourcesDirectory)/packages
Comment thread
samsharma2700 marked this conversation as resolved.
Outdated

- task: DownloadPipelineArtifact@2
displayName: Download Logging Package Artifacts
inputs:
artifactName: ${{ parameters.loggingArtifactsName }}
targetPath: $(packagePath)
targetPath: $(Build.SourcesDirectory)/packages
Comment thread
samsharma2700 marked this conversation as resolved.
Outdated

# Install the .NET SDK.
- template: /eng/pipelines/steps/install-dotnet.yml@self
Expand Down
6 changes: 4 additions & 2 deletions eng/pipelines/libraries/ci-build-variables.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,11 @@ variables:
- name: mdsPackageVersion
value: 7.0.0.$(Build.BuildNumber)-ci

# Output path for built NuGet packages
# Output path for built NuGet packages. This is intentionally separate from
# packages/ (where downloaded pipeline artifacts go) so that artifact publishing
# only uploads packages built by the current job.
Comment thread
samsharma2700 marked this conversation as resolved.
Outdated
- name: packagePath
value: $(Build.SourcesDirectory)/packages
value: $(Build.SourcesDirectory)/output

# Disable codesign validation injection for CI builds
- name: runCodesignValidationInjection
Expand Down
Loading