Skip to content

Test | Convert TvpQueryHintsTests to xunit assertions. #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdaigle merged 4 commits into from
Mar 9, 2026
Merged

Test | Convert TvpQueryHintsTests to xunit assertions. #4002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a4b219
Move QueryHintsTest from TvpTest to TvpQueryHintsTests
mdaigle Mar 5, 2026
dba080e
Split QueryHintsTest into individual test case methods
mdaigle Mar 5, 2026
bc41a57
Convert TvpQueryHintsTests to xunit assertions
mdaigle Mar 5, 2026
af1f0f1
Remove baseline files and parsing logic
mdaigle Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,22 +277,6 @@
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<Link>TvpColumnBoundaries_ReleaseMode_Azure.bsl</Link>
</Content>
<Content Include="SQL\ParameterTest\TvpQueryHints_DebugMode.bsl">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<Link>TvpQueryHints_DebugMode.bsl</Link>
</Content>
<Content Include="SQL\ParameterTest\TvpQueryHints_DebugMode_Azure.bsl">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<Link>TvpQueryHints_DebugMode_Azure.bsl</Link>
</Content>
<Content Include="SQL\ParameterTest\TvpQueryHints_ReleaseMode.bsl">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<Link>TvpQueryHints_ReleaseMode.bsl</Link>
</Content>
<Content Include="SQL\ParameterTest\TvpQueryHints_ReleaseMode_Azure.bsl">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<Link>TvpQueryHints_ReleaseMode_Azure.bsl</Link>
</Content>
<Content Include="SQL\ParameterTest\SqlVariantParameter_DebugMode.bsl">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<Link>SqlVariantParameter_DebugMode.bsl</Link>
Expand Down
342 changes: 245 additions & 97 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpQueryHintsTests.cs
View file
Open in desktop

Large diffs are not rendered by default.

30 changes: 0 additions & 30 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpQueryHints_DebugMode.bsl
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions ...soft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpQueryHints_DebugMode_Azure.bsl
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions ...icrosoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpQueryHints_ReleaseMode.bsl
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions ...ft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpQueryHints_ReleaseMode_Azure.bsl
View file
Open in desktop

This file was deleted.

238 changes: 0 additions & 238 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,244 +338,6 @@ private void TestTVPPermutations(SteStructuredTypeBoundaries bounds, bool runOnl
}
}

internal void QueryHintsTest()
{
using SqlConnection conn = new(_connStr);
conn.Open();

Guid randomizer = Guid.NewGuid();
string typeName = string.Format("dbo.[QHint_{0}]", randomizer);
string procName = string.Format("dbo.[QHint_Proc_{0}]", randomizer);
string createTypeSql = string.Format(
"CREATE TYPE {0} AS TABLE("
+ " c1 Int DEFAULT -1,"
+ " c2 NVarChar(40) DEFAULT N'DEFUALT',"
+ " c3 DateTime DEFAULT '1/1/2006',"
+ " c4 Int DEFAULT -1)",
typeName);
string createProcSql = string.Format(
"CREATE PROC {0}(@tvp {1} READONLY) AS SELECT TOP(2) * FROM @tvp ORDER BY c1", procName, typeName);
string dropSql = string.Format("DROP PROC {0}; DROP TYPE {1}", procName, typeName);

try
{
SqlCommand cmd = new(createTypeSql, conn);
cmd.ExecuteNonQuery();

cmd.CommandText = createProcSql;
cmd.ExecuteNonQuery();

cmd.CommandText = procName;
cmd.CommandType = CommandType.StoredProcedure;
SqlParameter param = cmd.Parameters.Add("@tvp", SqlDbType.Structured);

SqlMetaData[] columnMetadata;
List<SqlDataRecord> rows = new();
SqlDataRecord record;

Console.WriteLine("------- Sort order + uniqueness #1: simple -------");
columnMetadata = new SqlMetaData[] {
new SqlMetaData("", SqlDbType.Int, false, true, SortOrder.Ascending, 0),
new SqlMetaData("", SqlDbType.NVarChar, 40, false, true, SortOrder.Descending, 1),
new SqlMetaData("", SqlDbType.DateTime, false, true, SortOrder.Ascending, 2),
new SqlMetaData("", SqlDbType.Int, false, true, SortOrder.Descending, 3),
};

record = new SqlDataRecord(columnMetadata);
record.SetValues(0, "Z-value", DateTime.Parse("03/01/2000"), 5);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(1, "Y-value", DateTime.Parse("02/01/2000"), 6);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(1, "X-value", DateTime.Parse("01/01/2000"), 7);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(1, "X-value", DateTime.Parse("04/01/2000"), 8);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(1, "X-value", DateTime.Parse("04/01/2000"), 4);
rows.Add(record);

param.Value = rows;
using (SqlDataReader rdr = cmd.ExecuteReader())
{
WriteReader(rdr);
}
rows.Clear();

Console.WriteLine("------- Sort order + uniqueness #2: mixed order -------");
columnMetadata = new SqlMetaData[] {
new SqlMetaData("", SqlDbType.Int, false, true, SortOrder.Descending, 3),
new SqlMetaData("", SqlDbType.NVarChar, 40, false, true, SortOrder.Descending, 0),
new SqlMetaData("", SqlDbType.DateTime, false, true, SortOrder.Ascending, 2),
new SqlMetaData("", SqlDbType.Int, false, true, SortOrder.Ascending, 1),
};

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Z-value", DateTime.Parse("01/01/2000"), 1);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Z-value", DateTime.Parse("01/01/2000"), 2);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Y-value", DateTime.Parse("01/01/2000"), 3);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Y-value", DateTime.Parse("02/01/2000"), 3);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(5, "X-value", DateTime.Parse("03/01/2000"), 3);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(4, "X-value", DateTime.Parse("01/01/2000"), 3);
rows.Add(record);

param.Value = rows;
using (SqlDataReader rdr = cmd.ExecuteReader())
{
WriteReader(rdr);
}
rows.Clear();

Console.WriteLine("------- default column #1: outer subset -------");
columnMetadata = new SqlMetaData[] {
new SqlMetaData("", SqlDbType.Int, true, false, SortOrder.Unspecified, -1),
new SqlMetaData("", SqlDbType.NVarChar, 40, false, false, SortOrder.Unspecified, -1),
new SqlMetaData("", SqlDbType.DateTime, false, false, SortOrder.Unspecified, -1),
new SqlMetaData("", SqlDbType.Int, true, false, SortOrder.Unspecified, -1),
};

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Z-value", DateTime.Parse("01/01/2000"), 1);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Z-value", DateTime.Parse("01/01/2000"), 2);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Y-value", DateTime.Parse("01/01/2000"), 3);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Y-value", DateTime.Parse("02/01/2000"), 3);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(5, "X-value", DateTime.Parse("03/01/2000"), 3);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(4, "X-value", DateTime.Parse("01/01/2000"), 3);
rows.Add(record);

param.Value = rows;
using (SqlDataReader rdr = cmd.ExecuteReader())
{
WriteReader(rdr);
}
rows.Clear();

Console.WriteLine("------- default column #1: middle subset -------");
columnMetadata = new SqlMetaData[] {
new SqlMetaData("", SqlDbType.Int, false, false, SortOrder.Unspecified, -1),
new SqlMetaData("", SqlDbType.NVarChar, 40, true, false, SortOrder.Unspecified, -1),
new SqlMetaData("", SqlDbType.DateTime, true, false, SortOrder.Unspecified, -1),
new SqlMetaData("", SqlDbType.Int, false, false, SortOrder.Unspecified, -1),
};

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Z-value", DateTime.Parse("01/01/2000"), 1);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Z-value", DateTime.Parse("01/01/2000"), 2);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Y-value", DateTime.Parse("01/01/2000"), 3);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Y-value", DateTime.Parse("02/01/2000"), 3);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(5, "X-value", DateTime.Parse("03/01/2000"), 3);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(4, "X-value", DateTime.Parse("01/01/2000"), 3);
rows.Add(record);

param.Value = rows;
using (SqlDataReader rdr = cmd.ExecuteReader())
{
WriteReader(rdr);
}
rows.Clear();

Console.WriteLine("------- default column #1: all -------");
columnMetadata = new SqlMetaData[] {
new SqlMetaData("", SqlDbType.Int, true, false, SortOrder.Unspecified, -1),
new SqlMetaData("", SqlDbType.NVarChar, 40, true, false, SortOrder.Unspecified, -1),
new SqlMetaData("", SqlDbType.DateTime, true, false, SortOrder.Unspecified, -1),
new SqlMetaData("", SqlDbType.Int, true, false, SortOrder.Unspecified, -1),
};

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Z-value", DateTime.Parse("01/01/2000"), 1);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Z-value", DateTime.Parse("01/01/2000"), 2);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Y-value", DateTime.Parse("01/01/2000"), 3);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(6, "Y-value", DateTime.Parse("02/01/2000"), 3);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(5, "X-value", DateTime.Parse("03/01/2000"), 3);
rows.Add(record);

record = new SqlDataRecord(columnMetadata);
record.SetValues(4, "X-value", DateTime.Parse("01/01/2000"), 3);
rows.Add(record);

param.Value = rows;
using (SqlDataReader rdr = cmd.ExecuteReader())
{
WriteReader(rdr);
}
rows.Clear();

}
catch (Exception e)
{
Console.WriteLine(e.Message);
}
finally
{
SqlCommand cmd = new(dropSql, conn);
cmd.ExecuteNonQuery();
}
}

private static async Task RunPacketNumberWraparound(
WraparoundRowEnumerator enumerator,
CancellationToken cancellationToken)
Expand Down
Loading