Skip to content

[5.1] Dependency Cleanup #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulmedynski merged 10 commits into from
Jan 9, 2026
Merged

[5.1] Dependency Cleanup #3838

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4e6e2f7
- Removed unused dependencies across all driver and test projects.
paulmedynski Dec 10, 2025
a55bdcf
- Reverted the Microsoft.NET.Test.SDK package version since newer ver…
paulmedynski Dec 10, 2025
7e82d4e
- Removed unnecessary MSS references.
paulmedynski Dec 15, 2025
222f16c
- Fixed resource strings generation to work on Unix.
paulmedynski Dec 15, 2025
945a69a
- Added global.json for .NET SDK 8.0.
paulmedynski Dec 15, 2025
e64eed9
- Enhanced logging of TDS Server to see client/server endpoint details.
paulmedynski Dec 16, 2025
cac840c
- Fixed NRE in TDS Test server logging.
paulmedynski Dec 17, 2025
ea21587
- Added System.IdentityModel.Tokens.Jwt as a top-level dependency sin…
paulmedynski Dec 18, 2025
e4bf075
- Fixed malformed XML doc comment.
paulmedynski Dec 18, 2025
0c23397
- Bumped the MDS patch version number.
paulmedynski Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
<ItemGroup>
<PackageReference Include="Azure.Core" Version="$(AzureCoreVersion)" />
<PackageReference Include="System.Private.Uri" Version="$(SystemPrivateUriVersion)" />
<PackageReference Include="System.Text.Encodings.Web" Version="$(SystemTextEncodingsWebVersion)" />
<PackageReference Include="Azure.Security.KeyVault.Keys" Version="$(AzureSecurityKeyVaultKeysVersion)" />
<PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="$(MicrosoftExtensionsCachingMemoryVersion)" />
</ItemGroup>
Expand Down
4 changes: 0 additions & 4 deletions src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,11 @@
<ItemGroup Condition="'$(TargetGroup)' == 'netstandard'">
<Compile Include="Microsoft.Data.SqlClient.NetStandard.cs" />
</ItemGroup>
<ItemGroup Condition="'$(TargetGroup)' == 'netcoreapp'">
<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="$(SystemDiagnosticsDiagnosticSourceVersion)" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="System.Configuration.ConfigurationManager" Version="$(SystemConfigurationConfigurationManagerVersion)" />
<PackageReference Include="System.Security.Permissions" Version="$(SystemSecurityPermissionsVersion)" />
<PackageReference Include="System.Security.Principal.Windows" Version="$(SystemSecurityPrincipalWindowsVersion)" />
<PackageReference Include="System.Text.Encoding.CodePages" Version="$(SystemTextEncodingCodePagesVersion)" />
<PackageReference Include="System.Text.Encodings.Web" Version="$(SystemTextEncodingsWebVersion)" />
<PackageReference Include="Microsoft.Data.SqlClient.SNI.runtime" Version="$(MicrosoftDataSqlClientSniRuntimeVersion)" />
<!-- Enable the project reference for debugging purposes. -->
<!-- <ProjectReference Include="$(SqlServerSourceCode)\Microsoft.SqlServer.Server.csproj" /> -->
Expand Down
2 changes: 0 additions & 2 deletions src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,12 +963,10 @@
<PackageReference Include="System.Security.Permissions" Version="$(SystemSecurityPermissionsVersion)" />
<PackageReference Include="System.Security.Principal.Windows" Version="$(SystemSecurityPrincipalWindowsVersion)" />
<PackageReference Include="System.Text.Encoding.CodePages" Version="$(SystemTextEncodingCodePagesVersion)" />
<PackageReference Include="System.Text.Encodings.Web" Version="$(SystemTextEncodingsWebVersion)" />
<PackageReference Include="Microsoft.Data.SqlClient.SNI.runtime" Version="$(MicrosoftDataSqlClientSniRuntimeVersion)" />
<!-- Enable the project reference for debugging purposes. -->
<!-- <ProjectReference Include="$(SqlServerSourceCode)\Microsoft.SqlServer.Server.csproj" /> -->
<PackageReference Include="Microsoft.SqlServer.Server" Version="$(MicrosoftSqlServerServerVersion)" />
<PackageReference Condition="$(TargetGroup) == 'netcoreapp' " Include="System.Diagnostics.DiagnosticSource" Version="$(SystemDiagnosticsDiagnosticSourceVersion)" />
<!--
Azure.Core is explicitly referenced to avoid a transitive dependency on
a vulnerable version via Azure.Identity.
Expand Down
2 changes: 0 additions & 2 deletions src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,5 @@
<PackageReference Include="Microsoft.IdentityModel.JsonWebTokens" Version="$(MicrosoftIdentityModelJsonWebTokensVersion)" />
<PackageReference Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="$(MicrosoftIdentityModelProtocolsOpenIdConnectVersion)" />
<PackageReference Include="System.Buffers" Version="$(SystemBuffersVersion)" />
<PackageReference Include="System.Text.Encodings.Web" Version="$(SystemTextEncodingsWebVersion)" />
<PackageReference Include="System.Text.Json" Version="$(SystemTextJsonVersion)" />
</ItemGroup>
</Project>
2 changes: 0 additions & 2 deletions src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,8 +723,6 @@
<PackageReference Include="Microsoft.IdentityModel.JsonWebTokens" Version="$(MicrosoftIdentityModelJsonWebTokensVersion)" />
<PackageReference Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="$(MicrosoftIdentityModelProtocolsOpenIdConnectVersion)" />
<PackageReference Include="System.Buffers" Version="$(SystemBuffersVersion)" />
<PackageReference Include="System.Text.Encodings.Web" Version="$(SystemTextEncodingsWebVersion)" />
<PackageReference Include="System.Text.Json" Version="$(SystemTextJsonVersion)" />
</ItemGroup>

<!-- For compilation targeting .NET Framework using .NET SDKs. -->
Expand Down
3 changes: 0 additions & 3 deletions src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,8 @@
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Hosting" Version="$(MicrosoftExtensionsHostingVersion)" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="$(MicrosoftNETTestSdkVersion)" />
<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="$(SystemDiagnosticsDiagnosticSourceVersion)" />
<PackageReference Include="System.Text.Json" Version="$(SystemTextJsonVersion)" />
<PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonVersion)" />
<Reference Condition="'$(TargetGroup)'=='netfx'" Include="System.Transactions" />
<PackageReference Include="System.Private.Uri" Version="$(SystemPrivateUriVersion)" />
</ItemGroup>
<ItemGroup Condition="'$(TargetGroup)' == 'netcoreapp'">
<PackageReference Include="System.Data.Odbc" Version="$(SystemDataOdbcVersion)" />
Expand Down
2 changes: 0 additions & 2 deletions ...soft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,6 @@
</ItemGroup>
<ItemGroup>
<PackageReference Condition="$(ReferenceType.Contains('Package'))" Include="Microsoft.Identity.Client" Version="$(MicrosoftIdentityClientVersion)" />
<PackageReference Condition="$(ReferenceType.Contains('Package'))" Include="Microsoft.Win32.Registry" Version="$(MicrosoftWin32RegistryVersion)" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="$(AddOnsPath)AzureKeyVaultProvider\Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj" />
Expand All @@ -338,7 +337,6 @@
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="$(MicrosoftNETTestSdkVersion)" />
<PackageReference Condition="'$(TargetGroup)'=='netfx'" Include="Microsoft.SqlServer.Types" Version="$(MicrosoftSqlServerTypesVersion)" />
<PackageReference Condition="'$(TargetGroup)'!='netfx'" Include="System.ServiceProcess.ServiceController" Version="$(SystemServiceProcessServiceControllerVersion)" />
<PackageReference Include="System.Private.Uri" Version="$(SystemPrivateUriVersion)" />
</ItemGroup>

<!-- Ensure SNI DLLs are made available for .NET Framework project reference builds. -->
Expand Down
59 changes: 32 additions & 27 deletions tools/props/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="Current" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

<!-- MDS NuGet Package Version Information -->
<PropertyGroup>
<MdsVersionDefault>5.1.8</MdsVersionDefault>
<BuildNumber Condition="'$(BuildNumber)' == ''">0</BuildNumber>
Expand All @@ -12,6 +14,8 @@
<NugetPackageVersion Condition="'$(NugetPackageVersion)' == ''">$(MdsVersionDefault)-dev</NugetPackageVersion>
<Version>$(NugetPackageVersion)</Version>
</PropertyGroup>

<!-- MSS NuGet Package Version Information -->
<PropertyGroup>
<!-- This version section corresponds to version info of Microsoft.SqlServer.Server Assembly. -->
<!-- Should only be changed in future when a non-backwards compatible driver is released. -->
Expand All @@ -21,68 +25,69 @@
<SqlServerPackageVersion Condition="'$(SqlServerPackageVersion)' == ''">1.0.0-dev</SqlServerPackageVersion>
<SqlServerLibVersion>$(SqlServerPackageVersion)</SqlServerLibVersion>
</PropertyGroup>
<!-- NetFx project dependencies -->

<!-- AKV NuGet Package Version Information -->
<PropertyGroup>
<MicrosoftDataSqlClientSniVersion>5.1.2</MicrosoftDataSqlClientSniVersion>
<TestAKVProviderVersion>$(NugetPackageVersion)</TestAKVProviderVersion>
<TestMicrosoftDataSqlClientVersion>$(NugetPackageVersion)</TestMicrosoftDataSqlClientVersion>
</PropertyGroup>
<!-- NetFx and NetCore project dependencies -->

<!-- Common Dependencies - Shared by multiple driver or test projects-->
<PropertyGroup>
<AzureCoreVersion>1.41.0</AzureCoreVersion>
Comment thread
paulmedynski marked this conversation as resolved.
<AzureIdentityVersion>1.12.1</AzureIdentityVersion>
<MicrosoftIdentityClientVersion>4.76.0</MicrosoftIdentityClientVersion>
<MicrosoftIdentityModelProtocolsOpenIdConnectVersion>6.35.0</MicrosoftIdentityModelProtocolsOpenIdConnectVersion>
<MicrosoftIdentityModelJsonWebTokensVersion>6.35.0</MicrosoftIdentityModelJsonWebTokensVersion>
<SystemBuffersVersion>4.5.1</SystemBuffersVersion>
<SystemTextEncodingsWebVersion>6.0.1</SystemTextEncodingsWebVersion>
<SystemTextJsonVersion>6.0.11</SystemTextJsonVersion>
<MicrosoftIdentityModelProtocolsOpenIdConnectVersion>6.35.0</MicrosoftIdentityModelProtocolsOpenIdConnectVersion>
Comment thread
paulmedynski marked this conversation as resolved.
<SystemBuffersVersion>4.6.1</SystemBuffersVersion>
Comment thread
paulmedynski marked this conversation as resolved.
</PropertyGroup>
<!-- NetCore project dependencies -->

<!-- MDS NetFx project dependencies -->
<PropertyGroup>
<MicrosoftDataSqlClientSniVersion>5.1.2</MicrosoftDataSqlClientSniVersion>
Comment thread
paulmedynski marked this conversation as resolved.
</PropertyGroup>

<!-- MDS NetCore and NetStandard shared project dependencies -->
<PropertyGroup>
<MicrosoftWin32RegistryVersion>5.0.0</MicrosoftWin32RegistryVersion>
<MicrosoftDataSqlClientSniRuntimeVersion>5.1.2</MicrosoftDataSqlClientSniRuntimeVersion>
<SystemConfigurationConfigurationManagerVersion>6.0.1</SystemConfigurationConfigurationManagerVersion>
<MicrosoftSqlServerServerVersion>1.0.0</MicrosoftSqlServerServerVersion>
<SystemDiagnosticsDiagnosticSourceVersion>6.0.1</SystemDiagnosticsDiagnosticSourceVersion>
<SystemDiagnosticsPerformanceCounterVersion>6.0.1</SystemDiagnosticsPerformanceCounterVersion>
<SystemConfigurationConfigurationManagerVersion>6.0.1</SystemConfigurationConfigurationManagerVersion>
Comment thread
paulmedynski marked this conversation as resolved.
<SystemRuntimeCachingVersion>6.0.0</SystemRuntimeCachingVersion>
<SystemSecurityCryptographyCngVersion>5.0.0</SystemSecurityCryptographyCngVersion>
<SystemSecurityPermissionsVersion>6.0.0</SystemSecurityPermissionsVersion>
<SystemSecurityPrincipalWindowsVersion>5.0.0</SystemSecurityPrincipalWindowsVersion>
<SystemTextEncodingCodePagesVersion>6.0.0</SystemTextEncodingCodePagesVersion>
</PropertyGroup>
<!-- NetStandard project dependencies -->

<!-- MDS NetStandard project dependencies -->
<PropertyGroup>
<MicrosoftWin32RegistryVersion>5.0.0</MicrosoftWin32RegistryVersion>
Comment thread
paulmedynski marked this conversation as resolved.
<SystemRuntimeLoaderVersion>4.3.0</SystemRuntimeLoaderVersion>
<SystemSecurityCryptographyCngVersion>5.0.0</SystemSecurityCryptographyCngVersion>
Comment thread
paulmedynski marked this conversation as resolved.
</PropertyGroup>

<!-- AKV Provider project dependencies -->
<PropertyGroup>
<AzureCoreVersion>1.41.0</AzureCoreVersion>
<AzureSecurityKeyVaultKeysVersion>4.6.0</AzureSecurityKeyVaultKeysVersion>
<MicrosoftExtensionsCachingMemoryVersion>6.0.3</MicrosoftExtensionsCachingMemoryVersion>
<SystemPrivateUriVersion>4.3.2</SystemPrivateUriVersion>
</PropertyGroup>
<!-- Test Project Dependencies -->

<!-- Test project dependencies -->
<PropertyGroup>
<MicrosoftDotNetPlatformAbstractionsVersion>3.1.6</MicrosoftDotNetPlatformAbstractionsVersion>
<MicrosoftNETTestSdkVersion>17.12.0</MicrosoftNETTestSdkVersion>
<NewtonsoftJsonVersion>13.0.1</NewtonsoftJsonVersion>
<SystemRuntimeInteropServicesRuntimeInformationVersion>4.3.0</SystemRuntimeInteropServicesRuntimeInformationVersion>
<SystemDataOdbcVersion>6.0.1</SystemDataOdbcVersion>
<MicrosoftNETTestSdkVersion>17.14.0</MicrosoftNETTestSdkVersion>
<NewtonsoftJsonVersion>13.0.4</NewtonsoftJsonVersion>
<SystemDataOdbcVersion>6.0.2</SystemDataOdbcVersion>
<SystemFormatsAsn1Version>6.0.1</SystemFormatsAsn1Version>
<SystemSecurityCryptographyCngVersion>5.0.0</SystemSecurityCryptographyCngVersion>
<XunitVersion>2.9.3</XunitVersion>
<xunitrunnervisualstudioVersion>2.8.2</xunitrunnervisualstudioVersion>
<MicrosoftDotNetRemoteExecutorVersion>8.0.0-beta.25555.2</MicrosoftDotNetRemoteExecutorVersion>
<MicrosoftDotNetXunitExtensionsVersion>11.0.0-beta.25476.3</MicrosoftDotNetXunitExtensionsVersion>
<MicrosoftNETCoreRuntimeCoreCLRVersion>2.0.8</MicrosoftNETCoreRuntimeCoreCLRVersion>
<MicrosoftSqlServerSqlManagementObjectsVersion>172.52.0</MicrosoftSqlServerSqlManagementObjectsVersion>
<MicrosoftSqlServerTypesVersion>10.50.1600.1</MicrosoftSqlServerTypesVersion>
<BenchmarkDotNetVersion>0.13.2</BenchmarkDotNetVersion>
<SystemServiceProcessServiceControllerVersion>6.0.0</SystemServiceProcessServiceControllerVersion>
<MicrosoftExtensionsHostingVersion>6.0.1</MicrosoftExtensionsHostingVersion>
<MicrosoftExtensionsHostingVersion>8.0.1</MicrosoftExtensionsHostingVersion>
<MicrosoftNetFrameworkReferenceAssembliesVersion>1.0.3</MicrosoftNetFrameworkReferenceAssembliesVersion>
</PropertyGroup>
<PropertyGroup>
<TestAKVProviderVersion>$(NugetPackageVersion)</TestAKVProviderVersion>
<TestMicrosoftDataSqlClientVersion>$(NugetPackageVersion)</TestMicrosoftDataSqlClientVersion>
</PropertyGroup>
</Project>
6 changes: 0 additions & 6 deletions tools/specs/Microsoft.Data.SqlClient.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ When using NuGet 3.x this package requires at least version 3.4.</description>
<dependency id="Microsoft.IdentityModel.JsonWebTokens" version="6.35.0" />
<dependency id="Microsoft.IdentityModel.Protocols.OpenIdConnect" version="6.35.0" />
<dependency id="System.Buffers" version="4.5.1" />
<dependency id="System.Text.Encodings.Web" version="6.0.1" />
<dependency id="System.Text.Json" version="6.0.11" />
</group>
<group targetFramework="net6.0">
<!--
Expand All @@ -55,12 +53,10 @@ When using NuGet 3.x this package requires at least version 3.4.</description>
<dependency id="Microsoft.IdentityModel.Protocols.OpenIdConnect" version="6.35.0" />
<dependency id="Microsoft.SqlServer.Server" version="1.0.0"/>
<dependency id="System.Configuration.ConfigurationManager" version="6.0.1" exclude="Compile" />
<dependency id="System.Diagnostics.DiagnosticSource" version="6.0.1" exclude="Compile" />
<dependency id="System.Runtime.Caching" version="6.0.0" exclude="Compile" />
<dependency id="System.Security.Permissions" version="6.0.0" />
<dependency id="System.Security.Principal.Windows" version="5.0.0" exclude="Compile" />
<dependency id="System.Text.Encoding.CodePages" version="6.0.0" exclude="Compile" />
<dependency id="System.Text.Encodings.Web" version="6.0.1" />
</group>
<group targetFramework="netstandard2.0">
<!--
Expand All @@ -83,7 +79,6 @@ When using NuGet 3.x this package requires at least version 3.4.</description>
<dependency id="System.Security.Permissions" version="6.0.0" />
<dependency id="System.Security.Principal.Windows" version="5.0.0" exclude="Compile" />
<dependency id="System.Text.Encoding.CodePages" version="6.0.0" exclude="Compile" />
<dependency id="System.Text.Encodings.Web" version="6.0.1" />
</group>
<group targetFramework="netstandard2.1">
<!--
Expand All @@ -105,7 +100,6 @@ When using NuGet 3.x this package requires at least version 3.4.</description>
<dependency id="System.Security.Permissions" version="6.0.0" />
<dependency id="System.Security.Principal.Windows" version="5.0.0" exclude="Compile" />
<dependency id="System.Text.Encoding.CodePages" version="6.0.0" exclude="Compile" />
<dependency id="System.Text.Encodings.Web" version="6.0.1" />
</group>
</dependencies>
<frameworkAssemblies>
Expand Down
3 changes: 0 additions & 3 deletions tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,18 @@ Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyStoreProvider.SqlColumnEncrypti
<group targetFramework="net462">
<dependency id="Microsoft.Data.SqlClient" version="[5.1.3,5.2.0)" />
<dependency id="Azure.Core" version="1.41.0" />
<dependency id="System.Text.Encodings.Web" version="6.0.1" />
<dependency id="Azure.Security.KeyVault.Keys" version="4.6.0" />
<dependency id="Microsoft.Extensions.Caching.Memory" version="6.0.3" />
</group>
<group targetFramework="net6.0">
<dependency id="Microsoft.Data.SqlClient" version="[5.1.3,5.2.0)" />
<dependency id="Azure.Core" version="1.41.0" />
<dependency id="System.Text.Encodings.Web" version="6.0.1" />
<dependency id="Azure.Security.KeyVault.Keys" version="4.6.0" />
<dependency id="Microsoft.Extensions.Caching.Memory" version="6.0.3" />
</group>
<group targetFramework="netstandard2.0">
<dependency id="Microsoft.Data.SqlClient" version="[5.1.3,5.2.0)" />
<dependency id="Azure.Core" version="1.41.0" />
<dependency id="System.Text.Encodings.Web" version="6.0.1" />
<dependency id="Azure.Security.KeyVault.Keys" version="4.6.0" />
<dependency id="Microsoft.Extensions.Caching.Memory" version="6.0.3" />
</group>
Expand Down
Loading