-
Notifications
You must be signed in to change notification settings - Fork 321
[6.0] Fix code coverage job disk full #3814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes disk space issues in the code coverage job by switching to a custom 1ES image with more available disk space (ADO-MMS22-CodeCov instead of generic Azure Pipelines images). The change also refactors the code coverage job template to consolidate artifact download logic, improve parameter organization, and add debug output for disk usage monitoring.
Key Changes
- Switched code coverage job to use ADO-MMS22-CodeCov image with more disk space
- Refactored artifact download logic from caller to template, simplifying the interface
- Added disk usage debug output at multiple stages to help diagnose space issues
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
eng/pipelines/dotnet-sqlclient-ci-core.yml |
Removed defaultHostedPoolName variable and refactored code coverage job parameters to pass image, pool, and targetFrameworks instead of custom download steps |
eng/pipelines/common/templates/jobs/ci-code-coverage-job.yml |
Complete refactor with improved documentation, consolidated artifact download logic, added disk usage debug steps, parameter type improvements, and additional cleanup steps to free disk space during processing |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/6.0 #3814 +/- ##
===============================================
+ Coverage 75.86% 75.92% +0.05%
===============================================
Files 244 244
Lines 40221 40221
===============================================
+ Hits 30514 30537 +23
+ Misses 9707 9684 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Backport of #3798 to 6.0
The code coverage jobs are running out of disk space. They appear to consume upwards of 12GB of space to merge/convert 3GB of coverage logs from the various test jobs. We can diagnose why that is later. For now, I have: