Skip to content

Conversation

@paulmedynski
Copy link
Contributor

Description

Updated the MDS nuspec file to accurately report dependencies.

@paulmedynski paulmedynski added this to the 5.1.8 milestone Nov 13, 2025
Copilot AI review requested due to automatic review settings November 13, 2025 14:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the dependency declarations in the Microsoft.Data.SqlClient NuGet package specification (nuspec) file to accurately reflect the actual dependencies used by the project across different target frameworks.

Key Changes:

  • Removed incorrectly listed dependencies that are either built into the framework or only conditionally required
  • Reordered dependencies for better organization and readability
  • Ensured consistency between the nuspec file and the actual project references

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (499b095) to head (6934d19).
⚠️ Report is 2 commits behind head on release/5.1.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/5.1    #3764       +/-   ##
================================================
+ Coverage        72.29%   92.38%   +20.08%     
================================================
  Files              293        6      -287     
  Lines            61612      289    -61323     
================================================
- Hits             44544      267    -44277     
+ Misses           17068       22    -17046     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore ?
netfx ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski merged commit 211ec11 into release/5.1 Nov 13, 2025
80 checks passed
@paulmedynski paulmedynski deleted the dev/paul/release/5.1/nuspec branch November 13, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants