Skip to content

Conversation

@JRahnama
Copy link
Contributor

@JRahnama JRahnama commented Mar 9, 2022

No description provided.

Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kaur-Parminder Kaur-Parminder added the Area\Documentation Use this for issues that requires changes in public documentations/samples. label Mar 9, 2022
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update roadmap.md and README.md as well.

Copy link
Contributor

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the version before merging.

@JRahnama JRahnama marked this pull request as ready for review March 10, 2022 02:27
JRahnama and others added 2 commits March 9, 2022 18:36
### Added

- Added SqlDataSourceEnumerator. [#1430](https://github.com/dotnet/SqlClient/pull/1430)
- Added new attestation protocol `None` option to forgo enclave attestation when using VBS enclaves. [#1425](https://github.com/dotnet/SqlClient/pull/1425) and [#1419](https://github.com/dotnet/SqlClient/pull/1419)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can remove 'None' attestation since it's already in 4.1

@DavoudEshtehari DavoudEshtehari merged commit 5cebfbe into dotnet:main Mar 10, 2022
@JRahnama JRahnama deleted the preview1-version-5 branch September 29, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Documentation Use this for issues that requires changes in public documentations/samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants