#643 Conditionally including legacy packages #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perksey
approved these changes
Oct 17, 2021
|
@HurricanKai You're marked for review as the maths codeowner. Presume you're fine with this? |
|
Of course. Given the MSBuild magic works 😄 |
Perksey
pushed a commit
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
The
Microsoft.Bcl.HashCodeandUltz.Bcl.Halfpackages are now being conditionally included based on the TFM.Microsoft.Bcl.HashCodenetstandard2.0Ultz.Bcl.Halfnetstandard2.0;netstandard2.1;netcoreapp3.1Related issues, Discord discussions, or proposals
Discord link in related issue.
Further Comments
I tested this locally by running
dotnet buildwith--framework netstandard2.0for the five affected projects, then checking their references in ReSharper's Assembly Explorer. You can see the reference differences below:I did not have to modify any source files due to this change. I think that's because the two types in question are in the
Systemnamespace, which is included in nearly every source file.