A bunch of improvements to native library builds #2049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
38 tasks
alexrp
force-pushed
the
feature/natives
branch
15 times, most recently
from
a427837 to
fc5dacb
Compare
Member
|
Just going to kick off the builds for the purposes of review - just close the PRs as they're opened, I'm only interested in the checkmarks. |
alexrp
force-pushed
the
feature/natives
branch
2 times, most recently
from
27c4f51 to
e9d8ec6
Compare
These will mainly be used in CI workflows, so they're specific to Ubuntu 18.04 and 22.04.
Also clean up the build script.
Also clean up the build script.
The sndio backend takes a hard dependency on libsndio.so, unlike most other backends which load libraries dynamically. We don't want our libopenal.so to require users to install sndio.
This allows the build to pick them up and enable support.
This package is not multiarch-compatible in 22.04, so prioritize amd64.
This package is not multiarch-compatible in 22.04, so prioritize amd64.
…Fri Mar 15 00:10:50 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_VMAPPLE
…P Sat Mar 9 04:50:38 UTC 2024
…ntu SMP Sat Mar 9 04:50:38 UTC 2024
Update OpenALSoft binaries
Update SDL2 binaries
Beyley
requested changes
Apr 18, 2024
Contributor
Beyley
left a comment
Beyley
left a comment
There was a problem hiding this comment.
only thing left is just a missing comment, add that and ale li pona tawa mi, really nice work!
Member
|
Maybe it's worth factoring out the Ubuntu extras as well into a bash script? |
Collaborator
Author
The proper way to handle the duplication of logic in the native workflows is to switch them over to GitHub's reusable workflows feature, but that's a project for another day. |
Member
|
Force merging because CLA is sleeping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-O3.linux-x86support (was never officially supported by .NET).Contributes to #727.
Closes #2015.
Closes #2016.