Skip to content

Conversation

Beyley
Copy link
Contributor

@Beyley Beyley commented Dec 30, 2022

Summary of the PR

Adds bindings for the D3D11on12 header

Further Comments

D3D11 drivers on volterra are hot garbage, this may fix that

@Beyley Beyley requested a review from a team as a code owner December 30, 2022 20:49
@Perksey
Copy link
Member

Perksey commented Dec 30, 2022

NB: Your GPG signature is unverified.

@Perksey Perksey enabled auto-merge (squash) December 30, 2022 21:11
@Beyley
Copy link
Contributor Author

Beyley commented Dec 30, 2022

NB: Your GPG signature is unverified.

i commit this from my VM that i still havent setup a GPG key on because when i tried it made git segfault

@Beyley
Copy link
Contributor Author

Beyley commented Dec 31, 2022

Hmmm it seems this would make D3D11 have a hard dependency on D3D12, how is a way to go about this while still keeping the API good, if i put it into a Silk extension would the VTable extension methods still work?

@Beyley
Copy link
Contributor Author

Beyley commented Dec 31, 2022

Builds locally on my machine now as an extension

@Beyley Beyley disabled auto-merge December 31, 2022 09:41
@Perksey
Copy link
Member

Perksey commented Dec 31, 2022

Where does the extension come from?

@Perksey
Copy link
Member

Perksey commented Dec 31, 2022

Oh nvm I see it, yeah this seems sensible.

@Beyley
Copy link
Contributor Author

Beyley commented Jan 1, 2023

CI hit an OOM, restarting

@Beyley Beyley requested a review from Perksey January 1, 2023 09:18
@Perksey
Copy link
Member

Perksey commented Jan 1, 2023

A project has not been included in the solution and will not be shipped! "D:\a\Silk.NET\Silk.NET\src\Microsoft\Extensions\Silk.NET.Direct3D11.Extensions.D3D11On12\Silk.NET.Direct3D11.Extensions.D3D11On12.csproj" if this is acceptable please add the project name (excluding the path and extension) to the AllowedExclusions array in the NUKE Build.CI.AutoReview.cs file.

@Beyley
Copy link
Contributor Author

Beyley commented Jan 1, 2023

A project has not been included in the solution and will not be shipped! "D:\a\Silk.NET\Silk.NET\src\Microsoft\Extensions\Silk.NET.Direct3D11.Extensions.D3D11On12\Silk.NET.Direct3D11.Extensions.D3D11On12.csproj" if this is acceptable please add the project name (excluding the path and extension) to the AllowedExclusions array in the NUKE Build.CI.AutoReview.cs file.

aw damnit i forget to do that every time

@Perksey Perksey merged commit 93b39c4 into main Jan 2, 2023
@Perksey Perksey deleted the d3d11on12 branch January 2, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants