-
-
Notifications
You must be signed in to change notification settings - Fork 441
OpenGL Tutorials #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenGL Tutorials #1123
Conversation
Thanks for the contribution! I like what you've written, but I will be leaving a few comments 👀 |
Nicely done!
|
I've added most of the suggested changes - just left a couple that I will wait on your response for before I add them. I was originally going to change the |
Looking great! |
I mean, I did intend on adding it at some point. Don't know when I'll get a chance, but essentially it'll just end up being similar to the FancyImage shortcode (implemented in FancyImageShortCode.cs) to output something like <div class="alert alert-info">
Content...
</div> Adding a shortcode is very easy, tbh the Silk.NET.Statiq project is super easy to navigate so if you wanted to give it a go by all means do! If not, just leave it as is for now and hopefully someone gets round to it. |
Giving @ThomasMiz authority over this one given Thomas is probably the best maintainer for documentation/OpenGL user experience (and given I don't have anything to add :)) |
I'll take a look at adding it, it will be very handy to have for the tutorials. |
Co-authored-by: ThomasMiz <[email protected]>
Co-authored-by: ThomasMiz <[email protected]>
Co-authored-by: ThomasMiz <[email protected]>
Co-authored-by: ThomasMiz <[email protected]>
Co-authored-by: ThomasMiz <[email protected]>
Co-authored-by: ThomasMiz <[email protected]>
Co-authored-by: ThomasMiz <[email protected]>
i thought i commited all of these but GH didnt show me all of them Co-authored-by: ThomasMiz <[email protected]>
Co-authored-by: ThomasMiz <[email protected]>
Co-authored-by: ThomasMiz <[email protected]>
Co-authored-by: ThomasMiz <[email protected]>
Co-authored-by: ThomasMiz <[email protected]>
Co-authored-by: ThomasMiz <[email protected]>
Co-authored-by: ThomasMiz <[email protected]>
I appreciate the comments & suggestions! And yeah, it was a lot more effort than I was expecting too. Many tutorials just seem to be the "here copy this code and it works and you don't need to know why" sorta thing and I absolutely hate that, so I made sure to explain exactly what was going on. I've committed most of the suggestions, I've left a couple open since I won't commit that exact suggestion but I'll write close to it, and a couple have been left open as I don't agree with a couple of changes, but if you wish I am happy to change them too. I'll make the finishing touches tomorrow, and then if all is good it should be complete! |
Co-authored-by: ThomasMiz <[email protected]>
Seems like everything has now been resolved, so if all is good then this this PR should be ready. I'll get to the next set of tutorials soon and submit a new PR for those. Trying to write at least two at a time, depending on their complexity, and more if possible. |
Summary of the PR
This PR adds OpenGL tutorials to the Silk.NET website, using the code provided by the existing samples.
Related issues, Discord discussions, or proposals
https://discord.com/channels/521092042781229087/587346162802229298/1037331531619905596
Further Comments
I'd like to add a couple more tutorials before merging the PR, just so that there is enough to get started with.