Stabilize window frame compatibility test - #1153
Merged
Merged
Conversation
Wait for the relay to observe a dropped window frame before allowing the receiver to drain the channel, replacing a timing-dependent delay. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
TransferSucceeds_WhenWindowFramesAreDroppedassumed its background writer would exhaust the channel window within 200 ms. Under load in the Windows .NET Framework test run, the writer could start late; once the receiver began reading, it kept up on the zero-latency pipe and no growth request was emitted. The final non-vacuous assertion then failed.This is unrelated to #1148, which only changes TypeScript ESLint dependencies. The same test and assertion also failed on
mainin workflow run https://github.com/dotnet/Nerdbank.Streams/actions/runs/30677694206.Validation