-
-
Notifications
You must be signed in to change notification settings - Fork 177
Add tagName option to customize generated tag name
#875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together. I'm willing to merge, but can you address the few minor issues I call out?
No problem at all, thanks for creating and maintaining this tool! I've addressed all the things you pointed out, so should be good to merge if everything tests out correctly 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again.
This fixes #874 by adding a new option to the
version.jsonfile to allow customizing the generated tag name, defaulting to:{ "release": { "tagName": "v{version}" } }This default value is the same as was hardcoded before (see linked issue). resulting in the same output:
Changing this option to e.g.
release-{version}will result in the following output: