-
-
Notifications
You must be signed in to change notification settings - Fork 177
Set application version properties for Maui projects #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@espenrl Can you confirm that this works for you? If you can't confirm from this PR directly, you should be able to consume from our CI feed once this PR is merged as per the readme instructions. |
src/Nerdbank.GitVersioning.Tasks/build/Nerdbank.GitVersioning.targets
Outdated
Show resolved
Hide resolved
|
It's great you're including MAUI support into the library. I guess one must take into account MacOS and Tizen also to cover the full range of MAUI. I've added a comment about MacOS. I will investigate Tizen. |
|
It seems like MAUI Tizen doesn't use So while the following code will alter the version in the output package filename ( Let's skip Tizen support for now. <Target Name="NBGV_SetVersionfForMauiTizen"
Condition="'$(TargetPlatformIdentifier)' == 'tizen'"
BeforeTargets="_TizenResolveTpkPackageName"
DependsOnTargets="GetBuildVersion">
<PropertyGroup>
<ApplicationVersion>$(BuildVersionSimple)</ApplicationVersion>
<ApplicationDisplayVersion>$(BuildVersionSimple)</ApplicationDisplayVersion>
<TizenPackageVersion>$(BuildVersionSimple)</TizenPackageVersion>
</PropertyGroup>
</Target>Please see _TizenGetTpkInfoFromManifest |
|
Maybe the target names could be something along the lines of I'll test the functionality once there's a NuGet package on the CI feed. |
|
Sounds good. Let me know when/if you have something to work for Tizen. |
Closes #828