Fix Stream.Seek implementations to reliably shift position as required
#816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug is that `Stream.Read` was assumed to always fill the provided buffer, but in fact only a non-zero movement is contractually guaranteed.
1 task
1 task
This was referenced Sep 20, 2022
1 task
This was referenced Sep 20, 2022
brighid-bot
added a commit
to cythral/brighid-commands
that referenced
this pull request
Sep 20, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Nerdbank.GitVersioning](https://github.com/dotnet/Nerdbank.GitVersioning) | nuget | patch | `3.5.109` -> `3.5.113` | --- ### Release Notes <details> <summary>dotnet/Nerdbank.GitVersioning</summary> ### [`v3.5.113`](https://github.com/dotnet/Nerdbank.GitVersioning/releases/v3.5.113) #### What's Changed - DeltaStreamReader should interpret instruction with size 0 as 0x10000 by [@​marcin-krystianc](https://github.com/marcin-krystianc) in dotnet/Nerdbank.GitVersioning#818 #### New Contributors - [@​marcin-krystianc](https://github.com/marcin-krystianc) made their first contribution in dotnet/Nerdbank.GitVersioning#818 **Full Changelog**: dotnet/Nerdbank.GitVersioning@v3.5.112...v3.5.113 ### [`v3.5.112`](https://github.com/dotnet/Nerdbank.GitVersioning/releases/v3.5.112) #### What's Changed - Fix break in tests from VS 17.3 by [@​AArnott](https://github.com/AArnott) in dotnet/Nerdbank.GitVersioning#804 - Fix `Stream.Seek` implementations to reliably shift position as required by [@​AArnott](https://github.com/AArnott) in dotnet/Nerdbank.GitVersioning#816 **Full Changelog**: dotnet/Nerdbank.GitVersioning@v3.5.109...v3.5.112 </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
This was referenced Sep 20, 2022
Merged
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is that
Stream.Readwas assumed to always fill the provided buffer, but in fact only a non-zero movement is contractually guaranteed.Fixes #797