Skip to content

Conversation

@qmfrederik
Copy link
Contributor

@qmfrederik qmfrederik commented Mar 23, 2018

It looks like NB.GV isn't able to detect the branch name (e.g. master) when building in GitLab CI.

This PR adds support for GitLab CI and reading branch names & other data from the environment variables set by GitLab CI.

Not sure I got the semantics of all variables right, you can find an overview of which variables are set here:
https://docs.gitlab.com/ce/ci/variables/README.html

For those running on GitLab and looking for an immediate solution, here's how you can patch your .gitlab-ci.yml file to have GitLab pretend to be VSTS:

variables:
  BUILD_SOURCEBRANCH: '$CI_COMMIT_REF_NAME'
  SYSTEM_TEAMPROJECTID: '$CI_PROJECT_ID'

@AArnott
Copy link
Collaborator

AArnott commented Mar 24, 2018

Thanks

@AArnott AArnott merged commit 07ff6d7 into dotnet:master Mar 24, 2018
AArnott pushed a commit that referenced this pull request Sep 5, 2022
Bumps [xunit](https://github.com/xunit/xunit) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/xunit/xunit/releases)
- [Commits](xunit/xunit@2.4.1...2.4.2)

---
updated-dependencies:
- dependency-name: xunit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants