Skip to content

Retry file operations on access denied errors #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AArnott merged 1 commit into from
Jul 8, 2026
+8 −3
Merged

Retry file operations on access denied errors #1408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/Shared/Utilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ namespace Nerdbank.GitVersioning;

internal static class Utilities
{
private const int ProcessCannotAccessFileHR = unchecked((int)0x80070020);
private const int SharingViolation = unchecked((int)0x80070020); // ERROR_SHARING_VIOLATION
private const int AccessDenied = unchecked((int)0x80070005); // ERROR_ACCESS_DENIED

internal static void FileOperationWithRetry(Action operation)
{
Expand All @@ -20,11 +21,15 @@ internal static void FileOperationWithRetry(Action operation)
operation();
break;
}
catch (IOException ex) when (ex.HResult == ProcessCannotAccessFileHR && retriesLeft > 0)
catch (Exception ex) when (IsTransientFileAccessError(ex) && retriesLeft > 1)
{
Task.Delay(100).Wait();
Thread.Sleep(100);
continue;
}
Comment thread
AArnott marked this conversation as resolved.
}
}

private static bool IsTransientFileAccessError(Exception ex) => ex is
IOException { HResult: SharingViolation } or
UnauthorizedAccessException { HResult: AccessDenied };
}
Loading