improve examples for GetColumnName() breaking change

[Applesauce314]

Wording for provided example does not make it seem like an example
"Use the following code to get the column name for a specific table:"
see (#4024)

[dnfadmin]

All CLA requirements met.

[Applesauce314]

with dotnet 7 removing the obsolete overload, see (dotnet/efcore#26740), having better examples here is probably important.

[roji]

@Applesauce314 the breaking change seems quite sufficient as it is, providing a code sample for exactly what you're looking for:

Your proposed code sample shows your specific usage of the API (looping over all properties in all entity types), which isn't appropriate in a breaking change note.

[Applesauce314]

@Applesauce314 the breaking change seems quite sufficient as it is, providing a code sample for exactly what you're looking for:

Your proposed code sample shows your specific usage of the API (looping over all properties in all entity types), which isn't appropriate in a breaking change note.

I disagree that the breaking change mitigation as is provides sufficient guidance. It states use this line of code, a line of code that did not work for my use case, (though I was able to figure out how to perform the necessary steps to get the needed StoreObjectIdentifier), The linked issue (#4024) is an example of someone who was not able to figure out the same steps on their own.

I tweaked the original "example" that required you to know the table and schema name, both to more clearly state it is an example, and to give a little more clarity on what exactly it is you are doing.

The second example was to provide a example where EntityType was know, but the name of the table was not. (e.g. loop through all the properties on all the entities) which I though was probably a common use case. (As it was for me and the creator of the linked issue)

I actually expected discussion on this second example as the loop through everything code will certainly encounter problems if the feature that necessitated the change to this API was utilized. (you just replied before I was able to make my comment to that effect)

[roji]

The linked issue (#4024) is an example of someone who was not able to figure out the same steps on their own.

I suspect the problem in that issue is that the person did not see the breaking change note at all, otherwise they would have linked to it.

In any case, we'll discuss this as a team and see what people think.

[ajcvickers]

Superseded by #4050.