Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backing Fields|Basic configuration – bad link Including & Excluding Properties #3385

Closed
bravequickcleverfibreyarn opened this issue Aug 15, 2021 · 2 comments · Fixed by #3767
Closed

Backing Fields|Basic configuration – bad link Including & Excluding Properties #3385

bravequickcleverfibreyarn opened this issue Aug 15, 2021 · 2 comments · Fixed by #3767
Labels
area-model-building community-contribution good first issue This issue should be relatively straightforward to fix.
Milestone
6.0.0

Comments

@bravequickcleverfibreyarn
Copy link

From Basic configuration

For more information on which properties are included in the model, see Including & Excluding Properties.

Including & Excluding Properties link apparently links directly to article Entity Properties that has chapter Included and excluded properties.

I guess on some microinconsistence.

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@ajcvickers ajcvickers added area-model-building good first issue This issue should be relatively straightforward to fix. labels Aug 17, 2021
@ajcvickers ajcvickers added this to the Backlog milestone Aug 17, 2021
@Vadimyan
Copy link
Contributor

Since Including & Excluding Properties is a first section in Entity Properties page, so it's not big problem. But I think it'll be better to use concrete link to the section. I'm going to prepare a PR for this issue.

Vadimyan pushed a commit to Vadimyan/EntityFramework.Docs that referenced this issue Mar 15, 2022
Change a page link Entity properties to a section link Including & …
b3ae65e 
…Excluding Properties` in Backing Fields|Basic configuration.

Fixes dotnet#3385
@Vadimyan Vadimyan mentioned this issue Mar 15, 2022
Merged
@Vadimyan
Copy link
Contributor

Hi! I've prepared a small PR that changes the link from Entity Properties page to an exact section Including & Excluding Properties.

roji pushed a commit that referenced this issue Mar 15, 2022
@Vadimyan
Change a page link Entity properties to a section link Including & …
5276203 
…Excluding Properties` in Backing Fields|Basic configuration. (#3767)

Fixes #3385

Co-authored-by: Мартынов Вадим Андреевич <[email protected]>
@roji roji modified the milestones: Backlog, 6.0.0 Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building community-contribution good first issue This issue should be relatively straightforward to fix.
Projects
None yet
Milestone
6.0.0
4 participants
@ajcvickers @roji @Vadimyan @bravequickcleverfibreyarn