Ensure state is cleared and continue to multi-target .NET 8 for the interop bindings #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… performance and ensure correctness
tannergooding
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, the
_fileContentswas causing failures for--file a bcases becauseawas processed, then the translation unit was disposed.bwas then processed and may have reused the file handle ID fromacausing the key to "match" and a bad buffer to be returned.This also resolves #636 by ensuring the ClangSharp and ClangSharp.Interop libraries multi-target .NET 8
The command line tool (ClangSharpPInvokeGenerator) must only target .NET 10 due to its dependence on RID specific deployment. Likewise, multi-targeting the ClangSharp.PInvokeGenerator library is "too complex" and would negatively impact performance due to its dependence on
IAlternativeLookup<,>and the newLocktype.