Skip to content

Fix the yml #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2025
Merged

Fix the yml #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1683c63
Fix the yml
tannergooding Aug 17, 2025
a9d577f
Use signed char in the virtual tests so linux-arm64 works as expected
tannergooding Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ jobs:
publish-nightlies-github:
runs-on: ubuntu-latest
if: false
needs: [ windows-x64, linux-x64, macos-arm64, sign-nuget-preview, sign-nuget-release ]
needs: [ sign-nuget ]
steps:
- uses: actions/download-artifact@v4
with:
Expand Down
12 changes: 6 additions & 6 deletions tests/ClangSharp.PInvokeGenerator.UnitTests/CSharpCompatibleUnix/CXXMethodDeclarationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,7 @@ protected override Task VirtualTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -929,7 +929,7 @@ public unsafe partial struct MyStruct
public delegate void _MyVoidMethod(MyStruct* pThis);

[UnmanagedFunctionPointer(CallingConvention.ThisCall)]
[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public delegate sbyte _MyInt8Method(MyStruct* pThis);

[UnmanagedFunctionPointer(CallingConvention.ThisCall)]
Expand All @@ -946,7 +946,7 @@ public void MyVoidMethod()
}}
}}

[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
fixed (MyStruct* pThis = &this)
Expand Down Expand Up @@ -983,7 +983,7 @@ protected override Task VirtualWithVtblIndexAttributeTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -1007,7 +1007,7 @@ public unsafe partial struct MyStruct
public delegate void _MyVoidMethod(MyStruct* pThis);

[UnmanagedFunctionPointer(CallingConvention.ThisCall)]
[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public delegate sbyte _MyInt8Method(MyStruct* pThis);

[UnmanagedFunctionPointer(CallingConvention.ThisCall)]
Expand All @@ -1026,7 +1026,7 @@ public void MyVoidMethod()
}}

[VtblIndex(1)]
[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
fixed (MyStruct* pThis = &this)
Expand Down
12 changes: 6 additions & 6 deletions ...ClangSharp.PInvokeGenerator.UnitTests/CSharpCompatibleWindows/CXXMethodDeclarationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ protected override Task VirtualTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -924,7 +924,7 @@ public unsafe partial struct MyStruct
public delegate void _MyVoidMethod(MyStruct* pThis);

[UnmanagedFunctionPointer(CallingConvention.ThisCall)]
[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public delegate sbyte _MyInt8Method(MyStruct* pThis);

[UnmanagedFunctionPointer(CallingConvention.ThisCall)]
Expand All @@ -941,7 +941,7 @@ public void MyVoidMethod()
}}
}}

[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
fixed (MyStruct* pThis = &this)
Expand Down Expand Up @@ -978,7 +978,7 @@ protected override Task VirtualWithVtblIndexAttributeTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -1002,7 +1002,7 @@ public unsafe partial struct MyStruct
public delegate void _MyVoidMethod(MyStruct* pThis);

[UnmanagedFunctionPointer(CallingConvention.ThisCall)]
[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public delegate sbyte _MyInt8Method(MyStruct* pThis);

[UnmanagedFunctionPointer(CallingConvention.ThisCall)]
Expand All @@ -1021,7 +1021,7 @@ public void MyVoidMethod()
}}

[VtblIndex(1)]
[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
fixed (MyStruct* pThis = &this)
Expand Down
8 changes: 4 additions & 4 deletions tests/ClangSharp.PInvokeGenerator.UnitTests/CSharpDefaultUnix/CXXMethodDeclarationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ protected override Task VirtualTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -868,7 +868,7 @@ public void MyVoidMethod()
((delegate* unmanaged[Thiscall]<MyStruct*, void>)(lpVtbl[0]))((MyStruct*)Unsafe.AsPointer(ref this));
}}

[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
return ((delegate* unmanaged[Thiscall]<MyStruct*, sbyte>)(lpVtbl[1]))((MyStruct*)Unsafe.AsPointer(ref this));
Expand Down Expand Up @@ -896,7 +896,7 @@ protected override Task VirtualWithVtblIndexAttributeTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -922,7 +922,7 @@ public void MyVoidMethod()
}}

[VtblIndex(1)]
[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
return ((delegate* unmanaged[Thiscall]<MyStruct*, sbyte>)(lpVtbl[1]))((MyStruct*)Unsafe.AsPointer(ref this));
Expand Down
8 changes: 4 additions & 4 deletions tests/ClangSharp.PInvokeGenerator.UnitTests/CSharpDefaultWindows/CXXMethodDeclarationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ protected override Task VirtualTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -873,7 +873,7 @@ public void MyVoidMethod()
((delegate* unmanaged[Thiscall]<MyStruct*, void>)(lpVtbl[0]))((MyStruct*)Unsafe.AsPointer(ref this));
}}

[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
return ((delegate* unmanaged[Thiscall]<MyStruct*, sbyte>)(lpVtbl[1]))((MyStruct*)Unsafe.AsPointer(ref this));
Expand Down Expand Up @@ -901,7 +901,7 @@ protected override Task VirtualWithVtblIndexAttributeTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -927,7 +927,7 @@ public void MyVoidMethod()
}}

[VtblIndex(1)]
[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
return ((delegate* unmanaged[Thiscall]<MyStruct*, sbyte>)(lpVtbl[1]))((MyStruct*)Unsafe.AsPointer(ref this));
Expand Down
8 changes: 4 additions & 4 deletions tests/ClangSharp.PInvokeGenerator.UnitTests/CSharpLatestUnix/CXXMethodDeclarationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ protected override Task VirtualTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -868,7 +868,7 @@ public void MyVoidMethod()
((delegate* unmanaged[Thiscall]<MyStruct*, void>)(lpVtbl[0]))((MyStruct*)Unsafe.AsPointer(ref this));
}}

[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
return ((delegate* unmanaged[Thiscall]<MyStruct*, sbyte>)(lpVtbl[1]))((MyStruct*)Unsafe.AsPointer(ref this));
Expand Down Expand Up @@ -896,7 +896,7 @@ protected override Task VirtualWithVtblIndexAttributeTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -922,7 +922,7 @@ public void MyVoidMethod()
}}

[VtblIndex(1)]
[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
return ((delegate* unmanaged[Thiscall]<MyStruct*, sbyte>)(lpVtbl[1]))((MyStruct*)Unsafe.AsPointer(ref this));
Expand Down
8 changes: 4 additions & 4 deletions tests/ClangSharp.PInvokeGenerator.UnitTests/CSharpLatestWindows/CXXMethodDeclarationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ protected override Task VirtualTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -868,7 +868,7 @@ public void MyVoidMethod()
((delegate* unmanaged[Thiscall]<MyStruct*, void>)(lpVtbl[0]))((MyStruct*)Unsafe.AsPointer(ref this));
}}

[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
return ((delegate* unmanaged[Thiscall]<MyStruct*, sbyte>)(lpVtbl[1]))((MyStruct*)Unsafe.AsPointer(ref this));
Expand Down Expand Up @@ -896,7 +896,7 @@ protected override Task VirtualWithVtblIndexAttributeTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -922,7 +922,7 @@ public void MyVoidMethod()
}}

[VtblIndex(1)]
[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
return ((delegate* unmanaged[Thiscall]<MyStruct*, sbyte>)(lpVtbl[1]))((MyStruct*)Unsafe.AsPointer(ref this));
Expand Down
8 changes: 4 additions & 4 deletions tests/ClangSharp.PInvokeGenerator.UnitTests/CSharpPreviewUnix/CXXMethodDeclarationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ protected override Task VirtualTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -868,7 +868,7 @@ public void MyVoidMethod()
((delegate* unmanaged[Thiscall]<MyStruct*, void>)(lpVtbl[0]))((MyStruct*)Unsafe.AsPointer(ref this));
}}

[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
return ((delegate* unmanaged[Thiscall]<MyStruct*, sbyte>)(lpVtbl[1]))((MyStruct*)Unsafe.AsPointer(ref this));
Expand Down Expand Up @@ -896,7 +896,7 @@ protected override Task VirtualWithVtblIndexAttributeTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -922,7 +922,7 @@ public void MyVoidMethod()
}}

[VtblIndex(1)]
[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
return ((delegate* unmanaged[Thiscall]<MyStruct*, sbyte>)(lpVtbl[1]))((MyStruct*)Unsafe.AsPointer(ref this));
Expand Down
8 changes: 4 additions & 4 deletions tests/ClangSharp.PInvokeGenerator.UnitTests/CSharpPreviewWindows/CXXMethodDeclarationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ protected override Task VirtualTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -868,7 +868,7 @@ public void MyVoidMethod()
((delegate* unmanaged[Thiscall]<MyStruct*, void>)(lpVtbl[0]))((MyStruct*)Unsafe.AsPointer(ref this));
}}

[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
return ((delegate* unmanaged[Thiscall]<MyStruct*, sbyte>)(lpVtbl[1]))((MyStruct*)Unsafe.AsPointer(ref this));
Expand Down Expand Up @@ -896,7 +896,7 @@ protected override Task VirtualWithVtblIndexAttributeTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -922,7 +922,7 @@ public void MyVoidMethod()
}}

[VtblIndex(1)]
[return: NativeTypeName(""char"")]
[return: NativeTypeName(""signed char"")]
public sbyte MyInt8Method()
{{
return ((delegate* unmanaged[Thiscall]<MyStruct*, sbyte>)(lpVtbl[1]))((MyStruct*)Unsafe.AsPointer(ref this));
Expand Down
12 changes: 6 additions & 6 deletions tests/ClangSharp.PInvokeGenerator.UnitTests/XmlCompatibleUnix/CXXMethodDeclarationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,7 @@ protected override Task VirtualTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -1124,7 +1124,7 @@ virtual char MyInt8Method()
</param>
</delegate>
<delegate name=""_MyInt8Method"" access=""public"" convention=""ThisCall"">
<type native=""char"">sbyte</type>
<type native=""signed char"">sbyte</type>
<param name=""pThis"">
<type>MyStruct*</type>
</param>
Expand All @@ -1151,7 +1151,7 @@ virtual char MyInt8Method()
</body>
</function>
<function name=""MyInt8Method"" access=""public"" unsafe=""true"">
<type native=""char"">sbyte</type>
<type native=""signed char"">sbyte</type>
<body>
<code>fixed (MyStruct* pThis = &amp;this)
{{
Expand Down Expand Up @@ -1191,7 +1191,7 @@ protected override Task VirtualWithVtblIndexAttributeTestImpl()
{
virtual void MyVoidMethod() = 0;

virtual char MyInt8Method()
virtual signed char MyInt8Method()
{
return 0;
}
Expand All @@ -1216,7 +1216,7 @@ virtual char MyInt8Method()
</param>
</delegate>
<delegate name=""_MyInt8Method"" access=""public"" convention=""ThisCall"">
<type native=""char"">sbyte</type>
<type native=""signed char"">sbyte</type>
<param name=""pThis"">
<type>MyStruct*</type>
</param>
Expand All @@ -1243,7 +1243,7 @@ virtual char MyInt8Method()
</body>
</function>
<function name=""MyInt8Method"" access=""public"" unsafe=""true"" vtblindex=""1"">
<type native=""char"">sbyte</type>
<type native=""signed char"">sbyte</type>
<body>
<code>fixed (MyStruct* pThis = &amp;this)
{{
Expand Down
Loading
Loading