Skip to content

Exclude template specializations unless generate-template-bindings is set #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024
Merged

Exclude template specializations unless generate-template-bindings is set #551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sources/ClangSharp.PInvokeGenerator/PInvokeGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4587,7 +4587,7 @@ bool IsAlwaysIncluded(Cursor cursor)
bool IsExcludedByConfig(Cursor cursor)
{
return (_config.ExcludeFunctionsWithBody && (cursor is FunctionDecl functionDecl) && functionDecl.HasBody)
|| (!_config.GenerateTemplateBindings && (cursor is TemplateDecl));
|| (!_config.GenerateTemplateBindings && ((cursor is TemplateDecl) || (cursor is ClassTemplateSpecializationDecl)));
Copy link
Member

@tannergooding tannergooding May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other template related declarations that don't inherit from these two include:

  • FriendTemplateDecl
  • NonTypeTemplateParmDecl
  • TemplateParamObjectDecl
  • TemplateTypeParmDecl
  • VarTemplatePartialSpecializationDecl
  • VarTemplateSpecializationDecl

Of these, I think VarTemplateSpecializationDecl and VarTemplatePartialSpecializationDecl are the only two that don't require first being in an already skipped templated declaration context. But it may be important to look a bit more deeply.

}

bool IsExcludedByFile(Cursor cursor)
Expand Down