Skip to content

Ensure --include works for whole records and so on #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Ensure --include works for whole records and so on #487

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2418519
Ensure --include works for whole records and so on
tannergooding Nov 10, 2023
64ee00e
Update sources/ClangSharp.PInvokeGenerator/PInvokeGenerator.cs
tannergooding Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions sources/ClangSharp.PInvokeGenerator/PInvokeGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4699,16 +4699,21 @@ bool IsExcludedByName(Cursor cursor, ref uint isExcludedValue)
}

if (_config.IncludedNames.Count != 0 && !_config.IncludedNames.Contains(qualifiedName)
&& !_config.IncludedNames.Contains(dottedQualifiedName)
&& !_config.IncludedNames.Contains(qualifiedNameWithoutParameters)
&& !_config.IncludedNames.Contains(dottedQualifiedNameWithoutParameters)
&& !_config.IncludedNames.Contains(name))
&& !_config.IncludedNames.Contains(dottedQualifiedName)
&& !_config.IncludedNames.Contains(qualifiedNameWithoutParameters)
&& !_config.IncludedNames.Contains(dottedQualifiedNameWithoutParameters)
&& !_config.IncludedNames.Contains(name))
{
if (_config.LogExclusions)
var semanticParentCursor = cursor.SemanticParentCursor;

if ((semanticParentCursor is not null) && (IsExcluded(semanticParentCursor) || IsAlwaysIncluded(semanticParentCursor)))
{
AddDiagnostic(DiagnosticLevel.Info, $"Excluded {kind} '{qualifiedName}' as it was not in the include list");
if (_config.LogExclusions)
{
AddDiagnostic(DiagnosticLevel.Info, $"Excluded {kind} '{qualifiedName}' as it was not in the include list");
}
return true;
}
return true;
}

if ((isExcludedValue & 0b10) != 0)
Expand Down