Fixing C Incomplete Array to be treated as a Constant Array of length 1 #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #366 and ensures
IncompleteArrayis treated the same asConstantArray with Size=0given this is how MSVC and Clang both handle it.I'm going to separately work on also adding a
--with-specified-lengthparameter to the command line. This will allow theAsSpan()helper codegen to use the correct length coming from the relevant associated param/field for non-primitive fixed-sized buffers.Such a parameter would also allow the relevant metadata to be emitted as an associated attribute where relevant. Ideally in the future we could also automatically pull such info from the SAL annotations.